diff options
| author | Peter Eisentraut <peter@eisentraut.org> | 2020-12-11 19:15:30 +0100 |
|---|---|---|
| committer | Peter Eisentraut <peter@eisentraut.org> | 2020-12-11 19:15:30 +0100 |
| commit | d2a2808eb444986d2fe716a48e21993329142f3d (patch) | |
| tree | da7ab60d3feeaf2979bd1bd3301698ea515e03a6 /src/bin/pg_dump/pg_backup_archiver.h | |
| parent | 525e60b7429925d09fce1b5aa0bc2f23cfe6dd18 (diff) | |
| download | postgresql-d2a2808eb444986d2fe716a48e21993329142f3d.tar.gz postgresql-d2a2808eb444986d2fe716a48e21993329142f3d.zip | |
pg_dump: Don't use enums for defining bit mask values
This usage would mean that values of the enum type are potentially not
one of the enum values. Use macros instead, like everywhere else.
Discussion: https://www.postgresql.org/message-id/14dde730-1d34-260e-fa9d-7664df2d6313@enterprisedb.com
Diffstat (limited to 'src/bin/pg_dump/pg_backup_archiver.h')
| -rw-r--r-- | src/bin/pg_dump/pg_backup_archiver.h | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/src/bin/pg_dump/pg_backup_archiver.h b/src/bin/pg_dump/pg_backup_archiver.h index fb8d226d487..177360ed6e6 100644 --- a/src/bin/pg_dump/pg_backup_archiver.h +++ b/src/bin/pg_dump/pg_backup_archiver.h @@ -229,12 +229,9 @@ typedef enum #define RESTORE_PASS_LAST RESTORE_PASS_POST_ACL } RestorePass; -typedef enum -{ - REQ_SCHEMA = 0x01, /* want schema */ - REQ_DATA = 0x02, /* want data */ - REQ_SPECIAL = 0x04 /* for special TOC entries */ -} teReqs; +#define REQ_SCHEMA 0x01 /* want schema */ +#define REQ_DATA 0x02 /* want data */ +#define REQ_SPECIAL 0x04 /* for special TOC entries */ struct _archiveHandle { @@ -386,7 +383,7 @@ struct _tocEntry /* working state while dumping/restoring */ pgoff_t dataLength; /* item's data size; 0 if none or unknown */ - teReqs reqs; /* do we need schema and/or data of object */ + int reqs; /* do we need schema and/or data of object (REQ_* bit mask) */ bool created; /* set for DATA member if TABLE was created */ /* working state (needed only for parallel restore) */ @@ -436,7 +433,7 @@ extern void WriteDataChunksForTocEntry(ArchiveHandle *AH, TocEntry *te); extern ArchiveHandle *CloneArchive(ArchiveHandle *AH); extern void DeCloneArchive(ArchiveHandle *AH); -extern teReqs TocIDRequired(ArchiveHandle *AH, DumpId id); +extern int TocIDRequired(ArchiveHandle *AH, DumpId id); TocEntry *getTocEntryByDumpId(ArchiveHandle *AH, DumpId id); extern bool checkSeek(FILE *fp); |