aboutsummaryrefslogtreecommitdiff
path: root/src/bin/scripts/common.c
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2022-01-13 17:49:26 -0500
committerTom Lane <tgl@sss.pgh.pa.us>2022-01-13 17:49:26 -0500
commit45a3cefad6380cfc33303b7c294687d4b3ce634e (patch)
tree4b60985a979a1bfd48e7204cd3f6af125dd1b981 /src/bin/scripts/common.c
parent850c704c72a2e86c682948a36c65c1bd6618829f (diff)
downloadpostgresql-45a3cefad6380cfc33303b7c294687d4b3ce634e.tar.gz
postgresql-45a3cefad6380cfc33303b7c294687d4b3ce634e.zip
Fix ruleutils.c's dumping of whole-row Vars in more contexts.
Commit 7745bc352 intended to ensure that whole-row Vars would be printed with "::type" decoration in all contexts where plain "var.*" notation would result in star-expansion, notably in ROW() and VALUES() constructs. However, it missed the case of INSERT with a single-row VALUES, as reported by Timur Khanjanov. Nosing around ruleutils.c, I found a second oversight: the code for RowCompareExpr generates ROW() notation without benefit of an actual RowExpr, and naturally it wasn't in sync :-(. (The code for FieldStore also does this, but we don't expect that to generate strictly parsable SQL anyway, so I left it alone.) Back-patch to all supported branches. Discussion: https://postgr.es/m/efaba6f9-4190-56be-8ff2-7a1674f9194f@intrans.baku.az
Diffstat (limited to 'src/bin/scripts/common.c')
0 files changed, 0 insertions, 0 deletions