diff options
| author | Michael Paquier <michael@paquier.xyz> | 2019-08-27 09:11:31 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2019-08-27 09:11:31 +0900 |
| commit | 9acda731184c1ebdf99172cbb19d0404b7eebc37 (patch) | |
| tree | 0f6b56acfdf0b8943131e9147461db6990f25d13 /src/bin/scripts/scripts_parallel.c | |
| parent | fb57f40eec503d637bf01c298f5cb2472f0d4fdb (diff) | |
| download | postgresql-9acda731184c1ebdf99172cbb19d0404b7eebc37.tar.gz postgresql-9acda731184c1ebdf99172cbb19d0404b7eebc37.zip | |
Fix failure of --jobs with reindexdb and vacuumdb on Windows
FD_SETSIZE needs to be declared before winsock2.h, or it is possible to
run into buffer overflow issues when using --jobs. This is similar to
pgbench's solution done in a23c641.
This has been introduced by 71d84ef, and older versions have been using
the default value of FD_SETSIZE, defined at 64.
Per buildfarm member jacana, but this impacts all Windows animals
running the TAP tests. I have reproduced the failure locally to check
the patch.
Author: Michael Paquier
Reviewed-by: Andrew Dunstan
Discussion: https://postgr.es/m/20190826054000.GE7005@paquier.xyz
Backpatch-through: 9.5
Diffstat (limited to 'src/bin/scripts/scripts_parallel.c')
| -rw-r--r-- | src/bin/scripts/scripts_parallel.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/bin/scripts/scripts_parallel.c b/src/bin/scripts/scripts_parallel.c index 55bda9044b4..97435160e95 100644 --- a/src/bin/scripts/scripts_parallel.c +++ b/src/bin/scripts/scripts_parallel.c @@ -12,6 +12,10 @@ *------------------------------------------------------------------------- */ +#ifdef WIN32 +#define FD_SETSIZE 1024 /* must set before winsock2.h is included */ +#endif + #include "postgres_fe.h" #ifdef HAVE_SYS_SELECT_H |