diff options
| author | Noah Misch <noah@leadboat.com> | 2019-05-12 10:33:05 -0700 |
|---|---|---|
| committer | Noah Misch <noah@leadboat.com> | 2019-05-12 10:33:05 -0700 |
| commit | d02768ddd1791bab742cf131de726d0a36b3f337 (patch) | |
| tree | a2fa885d9a7076c75d96634467e196ba347ec7e5 /src/bin/scripts | |
| parent | 85ccb6899c6c8639bb3e5962ea3bcce5d886e613 (diff) | |
| download | postgresql-d02768ddd1791bab742cf131de726d0a36b3f337.tar.gz postgresql-d02768ddd1791bab742cf131de726d0a36b3f337.zip | |
Fail pgwin32_message_to_UTF16() for SQL_ASCII messages.
The function had been interpreting SQL_ASCII messages as UTF8, throwing
an error when they were invalid UTF8. The new behavior is consistent
with pg_do_encoding_conversion(). This affects LOG_DESTINATION_STDERR
and LOG_DESTINATION_EVENTLOG, which will send untranslated bytes to
write() and ReportEventA(). On buildfarm member bowerbird, enabling
log_connections caused an error whenever the role name was not valid
UTF8. Back-patch to 9.4 (all supported versions).
Discussion: https://postgr.es/m/20190512015615.GD1124997@rfd.leadboat.com
Diffstat (limited to 'src/bin/scripts')
| -rw-r--r-- | src/bin/scripts/t/200_connstr.pl | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/src/bin/scripts/t/200_connstr.pl b/src/bin/scripts/t/200_connstr.pl index a3aeee762f3..ee2523d0858 100644 --- a/src/bin/scripts/t/200_connstr.pl +++ b/src/bin/scripts/t/200_connstr.pl @@ -7,10 +7,8 @@ use Test::More tests => 3; # Tests to check connection string handling in utilities -# In a SQL_ASCII database, pgwin32_message_to_UTF16() needs to -# interpret everything as UTF8. We're going to use byte sequences -# that aren't valid UTF-8 strings, so that would fail. Use LATIN1, -# which accepts any byte and has a conversion from each byte to UTF-8. +# We're going to use byte sequences that aren't valid UTF-8 strings. Use +# LATIN1, which accepts any byte and has a conversion from each byte to UTF-8. $ENV{LC_ALL} = 'C'; $ENV{PGCLIENTENCODING} = 'LATIN1'; |