diff options
| author | Michael Paquier <michael@paquier.xyz> | 2021-11-29 13:36:13 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2021-11-29 13:36:13 +0900 |
| commit | 6fb7c5d67cdd55454fe6317f939a191f85e96473 (patch) | |
| tree | 74fdb6e0cf9a5732a2c31cb0f7867cf638232db2 /src/common/controldata_utils.c | |
| parent | 3804539e48e794781c6145c7f988f5d507418fa8 (diff) | |
| download | postgresql-6fb7c5d67cdd55454fe6317f939a191f85e96473.tar.gz postgresql-6fb7c5d67cdd55454fe6317f939a191f85e96473.zip | |
Centralize timestamp computation of control file on updates
This commit moves the timestamp computation of the control file within
the routine of src/common/ in charge of updating the backend's control
file, which is shared by multiple frontend tools (pg_rewind,
pg_checksums and pg_resetwal) and the backend itself.
This change has as direct effect to update the control file's timestamp
when writing the control file in pg_rewind and pg_checksums, something
that is helpful to keep track of control file updates for those
operations, something also tracked by the backend at startup within its
logs. This part is arguably a bug, as ControlFileData->time should be
updated each time a new version of the control file is written, but this
is a behavior change so no backpatch is done.
Author: Amul Sul
Reviewed-by: Nathan Bossart, Michael Paquier, Bharath Rupireddy
Discussion: https://postgr.es/m/CAAJ_b97nd_ghRpyFV9Djf9RLXkoTbOUqnocq11WGq9TisX09Fw@mail.gmail.com
Diffstat (limited to 'src/common/controldata_utils.c')
| -rw-r--r-- | src/common/controldata_utils.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/common/controldata_utils.c b/src/common/controldata_utils.c index 7d4af7881ea..4ce097c05ce 100644 --- a/src/common/controldata_utils.c +++ b/src/common/controldata_utils.c @@ -23,6 +23,7 @@ #include <unistd.h> #include <sys/stat.h> #include <fcntl.h> +#include <time.h> #include "access/xlog_internal.h" #include "catalog/pg_control.h" @@ -168,6 +169,9 @@ update_controlfile(const char *DataDir, StaticAssertStmt(sizeof(ControlFileData) <= PG_CONTROL_FILE_SIZE, "sizeof(ControlFileData) exceeds PG_CONTROL_FILE_SIZE"); + /* Update timestamp */ + ControlFile->time = (pg_time_t) time(NULL); + /* Recalculate CRC of control file */ INIT_CRC32C(ControlFile->crc); COMP_CRC32C(ControlFile->crc, |