diff options
| author | Alvaro Herrera <alvherre@alvh.no-ip.org> | 2019-10-17 09:58:01 +0200 |
|---|---|---|
| committer | Alvaro Herrera <alvherre@alvh.no-ip.org> | 2019-10-17 09:58:01 +0200 |
| commit | b304b2b65fde057a35286adf3ea69f5e154d1878 (patch) | |
| tree | 9d1d433d9f27d6ed13f7eb13914d792aab4d672f /src/fe_utils | |
| parent | 3af7c64fe70c0b9d1072c660ddb1cb87dbe0a9d3 (diff) | |
| download | postgresql-b304b2b65fde057a35286adf3ea69f5e154d1878.tar.gz postgresql-b304b2b65fde057a35286adf3ea69f5e154d1878.zip | |
Fix parallel restore of FKs to partitioned tables
When an FK constraint is created, it needs the index on the referenced
table to exist and be valid. When doing parallel pg_restore and the
referenced table was partitioned, this condition can sometimes not be
met, because pg_dump didn't emit sufficient object dependencies to
ensure so; this means that parallel pg_restore would fail in certain
conditions. Fix by having pg_dump make the FK constraint object
dependent on the partition attachment objects for the constraint's
referenced index.
This has been broken since f56f8f8da6af, so backpatch to Postgres 12.
Discussion: https://postgr.es/m/20191005224333.GA9738@alvherre.pgsql
Diffstat (limited to 'src/fe_utils')
| -rw-r--r-- | src/fe_utils/simple_list.c | 21 |
1 files changed, 21 insertions, 0 deletions
diff --git a/src/fe_utils/simple_list.c b/src/fe_utils/simple_list.c index 8d605140a74..2232e8db73e 100644 --- a/src/fe_utils/simple_list.c +++ b/src/fe_utils/simple_list.c @@ -114,3 +114,24 @@ simple_string_list_not_touched(SimpleStringList *list) } return NULL; } + +/* + * Append a pointer to the list. + * + * Caller must ensure that the pointer remains valid. + */ +void +simple_ptr_list_append(SimplePtrList *list, void *ptr) +{ + SimplePtrListCell *cell; + + cell = (SimplePtrListCell *) pg_malloc(sizeof(SimplePtrListCell)); + cell->next = NULL; + cell->ptr = ptr; + + if (list->tail) + list->tail->next = cell; + else + list->head = cell; + list->tail = cell; +} |