diff options
| author | Andres Freund <andres@anarazel.de> | 2014-09-22 16:48:14 +0200 |
|---|---|---|
| committer | Andres Freund <andres@anarazel.de> | 2014-09-22 17:49:34 +0200 |
| commit | 604f7956b9460192222dd37bd3baea24cb669a47 (patch) | |
| tree | b5724bd4bcb4a36e51c1fdd90edeb162edb30d24 /src/include/access/xlog_internal.h | |
| parent | 898f8a96ef9dfa79eac9ec1621a89e71fe16601c (diff) | |
| download | postgresql-604f7956b9460192222dd37bd3baea24cb669a47.tar.gz postgresql-604f7956b9460192222dd37bd3baea24cb669a47.zip | |
Improve code around the recently added rm_identify rmgr callback.
There are four weaknesses in728f152e07f998d2cb4fe5f24ec8da2c3bda98f2:
* append_init() in heapdesc.c was ugly and required that rm_identify
return values are only valid till the next call. Instead just add a
couple more switch() cases for the INIT_PAGE cases. Now the returned
value will always be valid.
* a couple rm_identify() callbacks missed masking xl_info with
~XLR_INFO_MASK.
* pg_xlogdump didn't map a NULL rm_identify to UNKNOWN or a similar
string.
* append_init() was called when id=NULL - which should never actually
happen. But it's better to be careful.
Diffstat (limited to 'src/include/access/xlog_internal.h')
| -rw-r--r-- | src/include/access/xlog_internal.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/include/access/xlog_internal.h b/src/include/access/xlog_internal.h index a1452b82b8e..27b98995557 100644 --- a/src/include/access/xlog_internal.h +++ b/src/include/access/xlog_internal.h @@ -244,9 +244,6 @@ struct XLogRecord; * "VACUUM". rm_desc can then be called to obtain additional detail for the * record, if available (e.g. the last block). * - * The return value from rm_identify is a pointer to a statically allocated - * buffer, and only valid until the next invocation of the callback. - * * RmgrTable[] is indexed by RmgrId values (see rmgrlist.h). */ typedef struct RmgrData |