diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2020-05-15 14:28:19 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2020-05-15 14:28:25 -0400 |
| commit | 5da14938f7bfb96b648ee3c47e7ea2afca5bcc4a (patch) | |
| tree | a637e548f3a39f0ebaef513f870964eb5dcecec9 /src/include/commands/async.h | |
| parent | 756abe2bc7608b38c579c510eb66f2bd80d10785 (diff) | |
| download | postgresql-5da14938f7bfb96b648ee3c47e7ea2afca5bcc4a.tar.gz postgresql-5da14938f7bfb96b648ee3c47e7ea2afca5bcc4a.zip | |
Rename SLRU structures and associated LWLocks.
Originally, the names assigned to SLRUs had no purpose other than
being shmem lookup keys, so not a lot of thought went into them.
As of v13, though, we're exposing them in the pg_stat_slru view and
the pg_stat_reset_slru function, so it seems advisable to take a bit
more care. Rename them to names based on the associated on-disk
storage directories (which fortunately we *did* think about, to some
extent; since those are also visible to DBAs, consistency seems like
a good thing). Also rename the associated LWLocks, since those names
are likewise user-exposed now as wait event names.
For the most part I only touched symbols used in the respective modules'
SimpleLruInit() calls, not the names of other related objects. This
renaming could have been taken further, and maybe someday we will do so.
But for now it seems undesirable to change the names of any globally
visible functions or structs, so some inconsistency is unavoidable.
(But I *did* terminate "oldserxid" with prejudice, as I found that
name both unreadable and not descriptive of the SLRU's contents.)
Table 27.12 needs re-alphabetization now, but I'll leave that till
after the other LWLock renamings I have in mind.
Discussion: https://postgr.es/m/28683.1589405363@sss.pgh.pa.us
Diffstat (limited to 'src/include/commands/async.h')
| -rw-r--r-- | src/include/commands/async.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/include/commands/async.h b/src/include/commands/async.h index d8814e9fec6..4c35394f818 100644 --- a/src/include/commands/async.h +++ b/src/include/commands/async.h @@ -18,7 +18,7 @@ /* * The number of SLRU page buffers we use for the notification queue. */ -#define NUM_ASYNC_BUFFERS 8 +#define NUM_NOTIFY_BUFFERS 8 extern bool Trace_notify; extern volatile sig_atomic_t notifyInterruptPending; |