diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2011-02-21 21:18:04 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2011-02-21 21:19:50 -0500 |
| commit | a210be772047575331fb6b0ab7b72043f81452ba (patch) | |
| tree | 2da45944d531ee734bde4ec9b69eb80599feefe6 /src/include/commands/trigger.h | |
| parent | fee7802770669398359c369aee83277dcc58edd1 (diff) | |
| download | postgresql-a210be772047575331fb6b0ab7b72043f81452ba.tar.gz postgresql-a210be772047575331fb6b0ab7b72043f81452ba.zip | |
Fix dangling-pointer problem in before-row update trigger processing.
ExecUpdate checked for whether ExecBRUpdateTriggers had returned a new
tuple value by seeing if the returned tuple was pointer-equal to the old
one. But the "old one" was in estate->es_junkFilter's result slot, which
would be scribbled on if we had done an EvalPlanQual update in response to
a concurrent update of the target tuple; therefore we were comparing a
dangling pointer to a live one. Given the right set of circumstances we
could get a false match, resulting in not forcing the tuple to be stored in
the slot we thought it was stored in. In the case reported by Maxim Boguk
in bug #5798, this led to "cannot extract system attribute from virtual
tuple" failures when trying to do "RETURNING ctid". I believe there is a
very-low-probability chance of more serious errors, such as generating
incorrect index entries based on the original rather than the
trigger-modified version of the row.
In HEAD, change all of ExecBRInsertTriggers, ExecIRInsertTriggers,
ExecBRUpdateTriggers, and ExecIRUpdateTriggers so that they continue to
have similar APIs. In the back branches I just changed
ExecBRUpdateTriggers, since there is no bug in the ExecBRInsertTriggers
case.
Diffstat (limited to 'src/include/commands/trigger.h')
| -rw-r--r-- | src/include/commands/trigger.h | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/src/include/commands/trigger.h b/src/include/commands/trigger.h index c213ac7a4ef..80a779ed0bd 100644 --- a/src/include/commands/trigger.h +++ b/src/include/commands/trigger.h @@ -132,16 +132,16 @@ extern void ExecBSInsertTriggers(EState *estate, ResultRelInfo *relinfo); extern void ExecASInsertTriggers(EState *estate, ResultRelInfo *relinfo); -extern HeapTuple ExecBRInsertTriggers(EState *estate, +extern TupleTableSlot *ExecBRInsertTriggers(EState *estate, ResultRelInfo *relinfo, - HeapTuple trigtuple); + TupleTableSlot *slot); extern void ExecARInsertTriggers(EState *estate, ResultRelInfo *relinfo, HeapTuple trigtuple, List *recheckIndexes); -extern HeapTuple ExecIRInsertTriggers(EState *estate, +extern TupleTableSlot *ExecIRInsertTriggers(EState *estate, ResultRelInfo *relinfo, - HeapTuple trigtuple); + TupleTableSlot *slot); extern void ExecBSDeleteTriggers(EState *estate, ResultRelInfo *relinfo); extern void ExecASDeleteTriggers(EState *estate, @@ -160,20 +160,20 @@ extern void ExecBSUpdateTriggers(EState *estate, ResultRelInfo *relinfo); extern void ExecASUpdateTriggers(EState *estate, ResultRelInfo *relinfo); -extern HeapTuple ExecBRUpdateTriggers(EState *estate, +extern TupleTableSlot *ExecBRUpdateTriggers(EState *estate, EPQState *epqstate, ResultRelInfo *relinfo, ItemPointer tupleid, - HeapTuple newtuple); + TupleTableSlot *slot); extern void ExecARUpdateTriggers(EState *estate, ResultRelInfo *relinfo, ItemPointer tupleid, HeapTuple newtuple, List *recheckIndexes); -extern HeapTuple ExecIRUpdateTriggers(EState *estate, +extern TupleTableSlot *ExecIRUpdateTriggers(EState *estate, ResultRelInfo *relinfo, - HeapTuple oldtuple, - HeapTuple newtuple); + HeapTuple trigtuple, + TupleTableSlot *slot); extern void ExecBSTruncateTriggers(EState *estate, ResultRelInfo *relinfo); extern void ExecASTruncateTriggers(EState *estate, |