diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2014-06-19 22:13:47 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2014-06-19 22:13:47 -0400 |
| commit | c1f8fb9bfb0d2a89f646b3186a004d6e4ebdecb4 (patch) | |
| tree | 39427db4b959016ea25b7d9afb0f4b8813cfc0a1 /src/include/executor/executor.h | |
| parent | 1442b426e5d724c90070f890fed36332f4b17884 (diff) | |
| download | postgresql-c1f8fb9bfb0d2a89f646b3186a004d6e4ebdecb4.tar.gz postgresql-c1f8fb9bfb0d2a89f646b3186a004d6e4ebdecb4.zip | |
Avoid leaking memory while evaluating arguments for a table function.
ExecMakeTableFunctionResult evaluated the arguments for a function-in-FROM
in the query-lifespan memory context. This is insignificant in simple
cases where the function relation is scanned only once; but if the function
is in a sub-SELECT or is on the inside of a nested loop, any memory
consumed during argument evaluation can add up quickly. (The potential for
trouble here had been foreseen long ago, per existing comments; but we'd
not previously seen a complaint from the field about it.) To fix, create
an additional temporary context just for this purpose.
Per an example from MauMau. Back-patch to all active branches.
Diffstat (limited to 'src/include/executor/executor.h')
| -rw-r--r-- | src/include/executor/executor.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/include/executor/executor.h b/src/include/executor/executor.h index f6386922930..4043b8f4483 100644 --- a/src/include/executor/executor.h +++ b/src/include/executor/executor.h @@ -229,6 +229,7 @@ extern Datum GetAttributeByName(HeapTupleHeader tuple, const char *attname, bool *isNull); extern Tuplestorestate *ExecMakeTableFunctionResult(ExprState *funcexpr, ExprContext *econtext, + MemoryContext argContext, TupleDesc expectedDesc, bool randomAccess); extern Datum ExecEvalExprSwitchContext(ExprState *expression, ExprContext *econtext, |