diff options
| author | Robert Haas <rhaas@postgresql.org> | 2017-12-19 12:21:56 -0500 |
|---|---|---|
| committer | Robert Haas <rhaas@postgresql.org> | 2017-12-19 12:21:56 -0500 |
| commit | 8526bcb2df76d5171b4f4d6dc7a97560a73a5eff (patch) | |
| tree | 8fd13e8cc570a6f996b9162ff4c76ce9190b3f0f /src/include/executor/nodeSort.h | |
| parent | 38fc54703ea4203a537c58332f697c546eaa4bcf (diff) | |
| download | postgresql-8526bcb2df76d5171b4f4d6dc7a97560a73a5eff.tar.gz postgresql-8526bcb2df76d5171b4f4d6dc7a97560a73a5eff.zip | |
Try again to fix accumulation of parallel worker instrumentation.
When a Gather or Gather Merge node is started and stopped multiple
times, accumulate instrumentation data only once, at the end, instead
of after each execution, to avoid recording inflated totals.
Commit 778e78ae9fa51e58f41cbdc72b293291d02d8984, the previous attempt
at a fix, instead reset the state after every execution, which worked
for the general instrumentation data but had problems for the additional
instrumentation specific to Sort and Hash nodes.
Report by hubert depesz lubaczewski. Analysis and fix by Amit Kapila,
following a design proposal from Thomas Munro, with a comment tweak
by me.
Discussion: http://postgr.es/m/20171127175631.GA405@depesz.com
Diffstat (limited to 'src/include/executor/nodeSort.h')
| -rw-r--r-- | src/include/executor/nodeSort.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/include/executor/nodeSort.h b/src/include/executor/nodeSort.h index cc61a9db697..627a04c3fdc 100644 --- a/src/include/executor/nodeSort.h +++ b/src/include/executor/nodeSort.h @@ -26,7 +26,6 @@ extern void ExecReScanSort(SortState *node); /* parallel instrumentation support */ extern void ExecSortEstimate(SortState *node, ParallelContext *pcxt); extern void ExecSortInitializeDSM(SortState *node, ParallelContext *pcxt); -extern void ExecSortReInitializeDSM(SortState *node, ParallelContext *pcxt); extern void ExecSortInitializeWorker(SortState *node, ParallelWorkerContext *pwcxt); extern void ExecSortRetrieveInstrumentation(SortState *node); |