diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2004-09-13 20:10:13 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2004-09-13 20:10:13 +0000 |
| commit | b2c4071299e02ed96d48d3c8e776de2fab36f88c (patch) | |
| tree | ff0db14826870f1c3fe46d94ea3a1e1697c658a7 /src/include/executor/spi.h | |
| parent | d69528881ab72eac5a9f154f23dbf549789c264d (diff) | |
| download | postgresql-b2c4071299e02ed96d48d3c8e776de2fab36f88c.tar.gz postgresql-b2c4071299e02ed96d48d3c8e776de2fab36f88c.zip | |
Redesign query-snapshot timing so that volatile functions in READ COMMITTED
mode see a fresh snapshot for each command in the function, rather than
using the latest interactive command's snapshot. Also, suppress fresh
snapshots as well as CommandCounterIncrement inside STABLE and IMMUTABLE
functions, instead using the snapshot taken for the most closely nested
regular query. (This behavior is only sane for read-only functions, so
the patch also enforces that such functions contain only SELECT commands.)
As per my proposal of 6-Sep-2004; I note that I floated essentially the
same proposal on 19-Jun-2002, but that discussion tailed off without any
action. Since 8.0 seems like the right place to be taking possibly
nontrivial backwards compatibility hits, let's get it done now.
Diffstat (limited to 'src/include/executor/spi.h')
| -rw-r--r-- | src/include/executor/spi.h | 18 |
1 files changed, 12 insertions, 6 deletions
diff --git a/src/include/executor/spi.h b/src/include/executor/spi.h index ef10789c614..d58f66ad314 100644 --- a/src/include/executor/spi.h +++ b/src/include/executor/spi.h @@ -2,7 +2,7 @@ * * spi.h * - * $PostgreSQL: pgsql/src/include/executor/spi.h,v 1.47 2004/08/29 05:06:56 momjian Exp $ + * $PostgreSQL: pgsql/src/include/executor/spi.h,v 1.48 2004/09/13 20:07:53 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -81,11 +81,17 @@ extern int SPI_connect(void); extern int SPI_finish(void); extern void SPI_push(void); extern void SPI_pop(void); +extern int SPI_execute(const char *src, bool read_only, int tcount); +extern int SPI_execute_plan(void *plan, Datum *Values, const char *Nulls, + bool read_only, int tcount); extern int SPI_exec(const char *src, int tcount); -extern int SPI_execp(void *plan, Datum *values, const char *Nulls, - int tcount); -extern int SPI_execp_current(void *plan, Datum *values, const char *Nulls, - bool useCurrentSnapshot, int tcount); +extern int SPI_execp(void *plan, Datum *Values, const char *Nulls, + int tcount); +extern int SPI_execute_snapshot(void *plan, + Datum *Values, const char *Nulls, + Snapshot snapshot, + Snapshot crosscheck_snapshot, + bool read_only, int tcount); extern void *SPI_prepare(const char *src, int nargs, Oid *argtypes); extern void *SPI_saveplan(void *plan); extern int SPI_freeplan(void *plan); @@ -113,7 +119,7 @@ extern void SPI_freetuple(HeapTuple pointer); extern void SPI_freetuptable(SPITupleTable *tuptable); extern Portal SPI_cursor_open(const char *name, void *plan, - Datum *Values, const char *Nulls); + Datum *Values, const char *Nulls, bool read_only); extern Portal SPI_cursor_find(const char *name); extern void SPI_cursor_fetch(Portal portal, bool forward, int count); extern void SPI_cursor_move(Portal portal, bool forward, int count); |