diff options
| author | David Rowley <drowley@postgresql.org> | 2021-04-01 13:33:23 +1300 |
|---|---|---|
| committer | David Rowley <drowley@postgresql.org> | 2021-04-01 13:33:23 +1300 |
| commit | 28b3e3905c982c42fb10ee800e6f881e9742c89d (patch) | |
| tree | 5368a84ddedf0c0da61fc9ec73ea148658821f0b /src/include/executor | |
| parent | b6002a796dc0bfe721db5eaa54ba9d24fd9fd416 (diff) | |
| download | postgresql-28b3e3905c982c42fb10ee800e6f881e9742c89d.tar.gz postgresql-28b3e3905c982c42fb10ee800e6f881e9742c89d.zip | |
Revert b6002a796
This removes "Add Result Cache executor node". It seems that something
weird is going on with the tracking of cache hits and misses as
highlighted by many buildfarm animals. It's not yet clear what the
problem is as other parts of the plan indicate that the cache did work
correctly, it's just the hits and misses that were being reported as 0.
This is especially a bad time to have the buildfarm so broken, so
reverting before too many more animals go red.
Discussion: https://postgr.es/m/CAApHDvq_hydhfovm4=izgWs+C5HqEeRScjMbOgbpC-jRAeK3Yw@mail.gmail.com
Diffstat (limited to 'src/include/executor')
| -rw-r--r-- | src/include/executor/executor.h | 7 | ||||
| -rw-r--r-- | src/include/executor/nodeResultCache.h | 31 |
2 files changed, 0 insertions, 38 deletions
diff --git a/src/include/executor/executor.h b/src/include/executor/executor.h index 26dcc4485eb..34dd861eff0 100644 --- a/src/include/executor/executor.h +++ b/src/include/executor/executor.h @@ -275,13 +275,6 @@ extern ExprState *ExecBuildGroupingEqual(TupleDesc ldesc, TupleDesc rdesc, const Oid *eqfunctions, const Oid *collations, PlanState *parent); -extern ExprState *ExecBuildParamSetEqual(TupleDesc desc, - const TupleTableSlotOps *lops, - const TupleTableSlotOps *rops, - const Oid *eqfunctions, - const Oid *collations, - const List *param_exprs, - PlanState *parent); extern ProjectionInfo *ExecBuildProjectionInfo(List *targetList, ExprContext *econtext, TupleTableSlot *slot, diff --git a/src/include/executor/nodeResultCache.h b/src/include/executor/nodeResultCache.h deleted file mode 100644 index df671d16f96..00000000000 --- a/src/include/executor/nodeResultCache.h +++ /dev/null @@ -1,31 +0,0 @@ -/*------------------------------------------------------------------------- - * - * nodeResultCache.h - * - * - * - * Portions Copyright (c) 2021, PostgreSQL Global Development Group - * Portions Copyright (c) 1994, Regents of the University of California - * - * src/include/executor/nodeResultCache.h - * - *------------------------------------------------------------------------- - */ -#ifndef NODERESULTCACHE_H -#define NODERESULTCACHE_H - -#include "nodes/execnodes.h" - -extern ResultCacheState *ExecInitResultCache(ResultCache *node, EState *estate, int eflags); -extern void ExecEndResultCache(ResultCacheState *node); -extern void ExecReScanResultCache(ResultCacheState *node); -extern double ExecEstimateCacheEntryOverheadBytes(double ntuples); -extern void ExecResultCacheEstimate(ResultCacheState *node, - ParallelContext *pcxt); -extern void ExecResultCacheInitializeDSM(ResultCacheState *node, - ParallelContext *pcxt); -extern void ExecResultCacheInitializeWorker(ResultCacheState *node, - ParallelWorkerContext *pwcxt); -extern void ExecResultCacheRetrieveInstrumentation(ResultCacheState *node); - -#endif /* NODERESULTCACHE_H */ |