diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2024-12-19 18:07:00 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2024-12-19 18:07:00 -0500 |
| commit | e0a2721f7c169b50617fed797d7336cd8f10bf77 (patch) | |
| tree | e0e3b0a910b11a86a23d929d7a6f892da5608bba /src/include/executor | |
| parent | f0b900086a370e45f730138d55da4f260d24809c (diff) | |
| download | postgresql-e0a2721f7c169b50617fed797d7336cd8f10bf77.tar.gz postgresql-e0a2721f7c169b50617fed797d7336cd8f10bf77.zip | |
Get rid of old version of BuildTupleHashTable().
It was reasonable to preserve the old API of BuildTupleHashTable()
in the back branches, but in HEAD we should actively discourage use
of that version. There are no remaining callers in core, so just
get rid of it. Then rename BuildTupleHashTableExt() back to
BuildTupleHashTable().
While at it, fix up the miserably-poorly-maintained header comment
for BuildTupleHashTable[Ext]. It looks like more than one patch in
this area has had the opinion that updating comments is beneath them.
Discussion: https://postgr.es/m/538343.1734646986@sss.pgh.pa.us
Diffstat (limited to 'src/include/executor')
| -rw-r--r-- | src/include/executor/executor.h | 22 |
1 files changed, 8 insertions, 14 deletions
diff --git a/src/include/executor/executor.h b/src/include/executor/executor.h index dee866e96bb..1c7fae09301 100644 --- a/src/include/executor/executor.h +++ b/src/include/executor/executor.h @@ -131,24 +131,18 @@ extern void execTuplesHashPrepare(int numCols, FmgrInfo **hashFunctions); extern TupleHashTable BuildTupleHashTable(PlanState *parent, TupleDesc inputDesc, - int numCols, AttrNumber *keyColIdx, + const TupleTableSlotOps *inputOps, + int numCols, + AttrNumber *keyColIdx, const Oid *eqfuncoids, FmgrInfo *hashfunctions, Oid *collations, - long nbuckets, Size additionalsize, + long nbuckets, + Size additionalsize, + MemoryContext metacxt, MemoryContext tablecxt, - MemoryContext tempcxt, bool use_variable_hash_iv); -extern TupleHashTable BuildTupleHashTableExt(PlanState *parent, - TupleDesc inputDesc, - const TupleTableSlotOps *inputOps, - int numCols, AttrNumber *keyColIdx, - const Oid *eqfuncoids, - FmgrInfo *hashfunctions, - Oid *collations, - long nbuckets, Size additionalsize, - MemoryContext metacxt, - MemoryContext tablecxt, - MemoryContext tempcxt, bool use_variable_hash_iv); + MemoryContext tempcxt, + bool use_variable_hash_iv); extern TupleHashEntry LookupTupleHashEntry(TupleHashTable hashtable, TupleTableSlot *slot, bool *isnew, uint32 *hash); |