diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2021-12-06 12:39:45 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2021-12-06 12:39:45 -0500 |
| commit | 0c9d84427f441602425b0e18be5cfe751d1d8ebe (patch) | |
| tree | 0413d147aa918d556f081a4720258d8cf0dba6d7 /src/include/fe_utils/string_utils.h | |
| parent | 5209c0ba0bfd16f23e38f707e487c0626e70564c (diff) | |
| download | postgresql-0c9d84427f441602425b0e18be5cfe751d1d8ebe.tar.gz postgresql-0c9d84427f441602425b0e18be5cfe751d1d8ebe.zip | |
Rethink pg_dump's handling of object ACLs.
Throw away most of the existing logic for this, as it was very
inefficient thanks to expensive sub-selects executed to collect
ACL data that we very possibly would have no interest in dumping.
Reduce the ACL handling in the initial per-object-type queries
to be just collection of the catalog ACL fields, as it was
originally. Fetch pg_init_privs data separately in a single
scan of that catalog, and do the merging calculations on the
client side. Remove the separate code path used for pre-9.6
source servers; there is no good reason to treat them differently
from newer servers that happen to have empty pg_init_privs.
Discussion: https://postgr.es/m/2273648.1634764485@sss.pgh.pa.us
Discussion: https://postgr.es/m/7d7eb6128f40401d81b3b7a898b6b4de@W2012-02.nidsa.loc
Diffstat (limited to 'src/include/fe_utils/string_utils.h')
| -rw-r--r-- | src/include/fe_utils/string_utils.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/include/fe_utils/string_utils.h b/src/include/fe_utils/string_utils.h index caafb97d293..e12e61cddb3 100644 --- a/src/include/fe_utils/string_utils.h +++ b/src/include/fe_utils/string_utils.h @@ -46,6 +46,7 @@ extern void appendConnStrVal(PQExpBuffer buf, const char *str); extern void appendPsqlMetaConnect(PQExpBuffer buf, const char *dbname); extern bool parsePGArray(const char *atext, char ***itemarray, int *nitems); +extern void appendPGArray(PQExpBuffer buffer, const char *value); extern bool appendReloptionsArray(PQExpBuffer buffer, const char *reloptions, const char *prefix, int encoding, bool std_strings); |