diff options
| author | Andres Freund <andres@anarazel.de> | 2022-04-04 14:32:52 -0700 |
|---|---|---|
| committer | Andres Freund <andres@anarazel.de> | 2022-04-04 14:32:52 -0700 |
| commit | 909eebf27b9e6aaa78fb3338f7d8fbc7fa174247 (patch) | |
| tree | 7554eb4996fce99f6cb5f0c2f71a3856c411ca2b /src/include/lib/dshash.h | |
| parent | 55e566fc4bc866d73541a3b28be5454bf8d666b0 (diff) | |
| download | postgresql-909eebf27b9e6aaa78fb3338f7d8fbc7fa174247.tar.gz postgresql-909eebf27b9e6aaa78fb3338f7d8fbc7fa174247.zip | |
dshash: revise sequential scan support.
The previous coding of dshash_seq_next(), on the first call, accessed
status->hash_table->size_log2 without holding a partition lock and without
guaranteeing that ensure_valid_bucket_pointers() had ever been called.
That oversight turns out to not have immediately visible effects, because
bucket 0 is always in partition 0, and ensure_valid_bucket_pointers() was
called after acquiring the partition lock. However,
PARTITION_FOR_BUCKET_INDEX() with a size_log2 of 0 ends up triggering formally
undefined behaviour.
Simplify by accessing partition 0, without using PARTITION_FOR_BUCKET_INDEX().
While at it, remove dshash_get_current(), there is no convincing use
case. Also polish a few comments.
Author: Andres Freund <andres@anarazel.de>
Reviewed-By: Thomas Munro <thomas.munro@gmail.com>
Discussion: https://postgr.es/m/CA+hUKGL9hY_VY=+oUK+Gc1iSRx-Ls5qeYJ6q=dQVZnT3R63Taw@mail.gmail.com
Diffstat (limited to 'src/include/lib/dshash.h')
| -rw-r--r-- | src/include/lib/dshash.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/include/lib/dshash.h b/src/include/lib/dshash.h index caeb60ad723..28f8db2eabc 100644 --- a/src/include/lib/dshash.h +++ b/src/include/lib/dshash.h @@ -101,7 +101,6 @@ extern void dshash_seq_init(dshash_seq_status *status, dshash_table *hash_table, extern void *dshash_seq_next(dshash_seq_status *status); extern void dshash_seq_term(dshash_seq_status *status); extern void dshash_delete_current(dshash_seq_status *status); -extern void *dshash_get_current(dshash_seq_status *status); /* Convenience hash and compare functions wrapping memcmp and tag_hash. */ extern int dshash_memcmp(const void *a, const void *b, size_t size, void *arg); |