diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2022-08-17 15:35:51 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2022-08-17 15:35:51 -0400 |
| commit | 6569ca43973b754e8213072c8ddcae9e7baf2aaa (patch) | |
| tree | 396627f9ae41b4bd5f069cd20c142d30d62b8b59 /src/include/nodes | |
| parent | efd0c16becbf45e3b0215e124fde75fee8fcbce4 (diff) | |
| download | postgresql-6569ca43973b754e8213072c8ddcae9e7baf2aaa.tar.gz postgresql-6569ca43973b754e8213072c8ddcae9e7baf2aaa.zip | |
Make PlaceHolderInfo lookup O(1).
Up to now we've just searched the placeholder_list when we want to
find the PlaceHolderInfo with a given ID. While there's no evidence
of that being a problem in the field, an upcoming patch will add
find_placeholder_info() calls in build_joinrel_tlist(), which seems
likely to make it more of an issue: a joinrel emitting lots of
PlaceHolderVars would incur O(N^2) cost, and we might be building
a lot of joinrels in complex queries. Hence, add an array that
can be indexed directly by phid to make the lookups constant-time.
Discussion: https://postgr.es/m/1405792.1660677844@sss.pgh.pa.us
Diffstat (limited to 'src/include/nodes')
| -rw-r--r-- | src/include/nodes/pathnodes.h | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/src/include/nodes/pathnodes.h b/src/include/nodes/pathnodes.h index 3b065139e68..b310d3c6fd3 100644 --- a/src/include/nodes/pathnodes.h +++ b/src/include/nodes/pathnodes.h @@ -357,6 +357,11 @@ struct PlannerInfo /* list of PlaceHolderInfos */ List *placeholder_list; + /* array of PlaceHolderInfos indexed by phid */ + struct PlaceHolderInfo **placeholder_array pg_node_attr(read_write_ignore, array_size(placeholder_array_size)); + /* allocated size of array */ + int placeholder_array_size pg_node_attr(read_write_ignore); + /* list of ForeignKeyOptInfos */ List *fkey_list; |