diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2012-03-23 17:29:57 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2012-03-23 17:29:57 -0400 |
| commit | 0339047bc93147c1c6f78f867ae6b0c215406235 (patch) | |
| tree | 116a4cd10a9eb1b0b6beb4cf871bc126c504572a /src/include/parser/parse_clause.h | |
| parent | e08b4101e1daa2f4e6644330918177a10cac0aab (diff) | |
| download | postgresql-0339047bc93147c1c6f78f867ae6b0c215406235.tar.gz postgresql-0339047bc93147c1c6f78f867ae6b0c215406235.zip | |
Code review for protransform patches.
Fix loss of previous expression-simplification work when a transform
function fires: we must not simply revert to untransformed input tree.
Instead build a dummy FuncExpr node to pass to the transform function.
This has the additional advantage of providing a simpler, more uniform
API for transform functions.
Move documentation to a somewhat less buried spot, relocate some
poorly-placed code, be more wary of null constants and invalid typmod
values, add an opr_sanity check on protransform function signatures,
and some other minor cosmetic adjustments.
Note: although this patch touches pg_proc.h, no need for catversion
bump, because the changes are cosmetic and don't actually change the
intended catalog contents.
Diffstat (limited to 'src/include/parser/parse_clause.h')
| -rw-r--r-- | src/include/parser/parse_clause.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/include/parser/parse_clause.h b/src/include/parser/parse_clause.h index f8eb41aad45..fd3fc8f5709 100644 --- a/src/include/parser/parse_clause.h +++ b/src/include/parser/parse_clause.h @@ -44,6 +44,4 @@ extern List *transformDistinctOnClause(ParseState *pstate, List *distinctlist, extern Index assignSortGroupRef(TargetEntry *tle, List *tlist); extern bool targetIsInSortList(TargetEntry *tle, Oid sortop, List *sortList); -extern Node *relabel_to_typmod(Node *expr, int32 typmod); - #endif /* PARSE_CLAUSE_H */ |