diff options
| author | Robert Haas <rhaas@postgresql.org> | 2016-03-08 08:46:48 -0500 |
|---|---|---|
| committer | Robert Haas <rhaas@postgresql.org> | 2016-03-08 08:46:48 -0500 |
| commit | 77a1d1e79892a20ed15a67be42b96949b8546bf6 (patch) | |
| tree | 2558fdac8319cde7e1d6fa9280467580b273e074 /src/include/storage/bufpage.h | |
| parent | ba0a198fb133eb3426bffdc2e369cce1bafe1612 (diff) | |
| download | postgresql-77a1d1e79892a20ed15a67be42b96949b8546bf6.tar.gz postgresql-77a1d1e79892a20ed15a67be42b96949b8546bf6.zip | |
Department of second thoughts: remove PD_ALL_FROZEN.
Commit a892234f830e832110f63fc0a2afce2fb21d1584 added a second bit per
page to the visibility map, which still seems like a good idea, but it
also added a second page-level bit alongside PD_ALL_VISIBLE to track
whether the visibility map bit was set. That no longer seems like a
clever plan, because we don't really need that bit for anything. We
always clear both bits when the page is modified anyway.
Patch by me, reviewed by Kyotaro Horiguchi and Masahiko Sawada.
Diffstat (limited to 'src/include/storage/bufpage.h')
| -rw-r--r-- | src/include/storage/bufpage.h | 11 |
1 files changed, 2 insertions, 9 deletions
diff --git a/src/include/storage/bufpage.h b/src/include/storage/bufpage.h index 0b023b3d853..2ce3be765c0 100644 --- a/src/include/storage/bufpage.h +++ b/src/include/storage/bufpage.h @@ -178,10 +178,8 @@ typedef PageHeaderData *PageHeader; * tuple? */ #define PD_ALL_VISIBLE 0x0004 /* all tuples on page are visible to * everyone */ -#define PD_ALL_FROZEN 0x0008 /* all tuples on page are completely - frozen */ -#define PD_VALID_FLAG_BITS 0x000F /* OR of all valid pd_flags bits */ +#define PD_VALID_FLAG_BITS 0x0007 /* OR of all valid pd_flags bits */ /* * Page layout version number 0 is for pre-7.3 Postgres releases. @@ -369,12 +367,7 @@ typedef PageHeaderData *PageHeader; #define PageSetAllVisible(page) \ (((PageHeader) (page))->pd_flags |= PD_ALL_VISIBLE) #define PageClearAllVisible(page) \ - (((PageHeader) (page))->pd_flags &= ~(PD_ALL_VISIBLE | PD_ALL_FROZEN)) - -#define PageIsAllFrozen(page) \ - (((PageHeader) (page))->pd_flags & PD_ALL_FROZEN) -#define PageSetAllFrozen(page) \ - (((PageHeader) (page))->pd_flags |= PD_ALL_FROZEN) + (((PageHeader) (page))->pd_flags &= ~PD_ALL_VISIBLE) #define PageIsPrunable(page, oldestxmin) \ ( \ |