diff options
| author | Noah Misch <noah@leadboat.com> | 2019-04-03 17:03:46 -0700 |
|---|---|---|
| committer | Noah Misch <noah@leadboat.com> | 2019-04-03 17:03:46 -0700 |
| commit | 2f932f71d9f2963bbd201129d7b971c8f5f077fd (patch) | |
| tree | a9647622166d61e3b7668eca618f37c47d864f5f /src/include/storage/ipc.h | |
| parent | af052daec5aa282eab2d22fa3b24d6109a30c2f3 (diff) | |
| download | postgresql-2f932f71d9f2963bbd201129d7b971c8f5f077fd.tar.gz postgresql-2f932f71d9f2963bbd201129d7b971c8f5f077fd.zip | |
Consistently test for in-use shared memory.
postmaster startup scrutinizes any shared memory segment recorded in
postmaster.pid, exiting if that segment matches the current data
directory and has an attached process. When the postmaster.pid file was
missing, a starting postmaster used weaker checks. Change to use the
same checks in both scenarios. This increases the chance of a startup
failure, in lieu of data corruption, if the DBA does "kill -9 `head -n1
postmaster.pid` && rm postmaster.pid && pg_ctl -w start". A postmaster
will no longer recycle segments pertaining to other data directories.
That's good for production, but it's bad for integration tests that
crash a postmaster and immediately delete its data directory. Such a
test now leaks a segment indefinitely. No "make check-world" test does
that. win32_shmem.c already avoided all these problems. In 9.6 and
later, enhance PostgresNode to facilitate testing. Back-patch to 9.4
(all supported versions).
Reviewed by Daniel Gustafsson and Kyotaro HORIGUCHI.
Discussion: https://postgr.es/m/20130911033341.GD225735@tornado.leadboat.com
Diffstat (limited to 'src/include/storage/ipc.h')
| -rw-r--r-- | src/include/storage/ipc.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/include/storage/ipc.h b/src/include/storage/ipc.h index 0660252faf2..e9b243fe7d4 100644 --- a/src/include/storage/ipc.h +++ b/src/include/storage/ipc.h @@ -76,6 +76,6 @@ extern void on_exit_reset(void); /* ipci.c */ extern PGDLLIMPORT shmem_startup_hook_type shmem_startup_hook; -extern void CreateSharedMemoryAndSemaphores(bool makePrivate, int port); +extern void CreateSharedMemoryAndSemaphores(int port); #endif /* IPC_H */ |