diff options
| author | Peter Eisentraut <peter_e@gmx.net> | 2018-03-28 18:57:10 -0400 |
|---|---|---|
| committer | Peter Eisentraut <peter_e@gmx.net> | 2018-03-28 19:03:26 -0400 |
| commit | 056a5a3f63f1a29d9266165ee6e25c6a51ddd63c (patch) | |
| tree | 81a14413e9303f536c9c3f8c889bc2d265fa75c8 /src/include/utils/portal.h | |
| parent | a2894cce544d120199a1a90469073796d055bb60 (diff) | |
| download | postgresql-056a5a3f63f1a29d9266165ee6e25c6a51ddd63c.tar.gz postgresql-056a5a3f63f1a29d9266165ee6e25c6a51ddd63c.zip | |
Allow committing inside cursor loop
Previously, committing or aborting inside a cursor loop was prohibited
because that would close and remove the cursor. To allow that,
automatically convert such cursors to holdable cursors so they survive
commits or rollbacks. Portals now have a new state "auto-held", which
means they have been converted automatically from pinned. An auto-held
portal is kept on transaction commit or rollback, but is still removed
when returning to the main loop on error.
This supports all languages that have cursor loop constructs: PL/pgSQL,
PL/Python, PL/Perl.
Reviewed-by: Ildus Kurbangaliev <i.kurbangaliev@postgrespro.ru>
Diffstat (limited to 'src/include/utils/portal.h')
| -rw-r--r-- | src/include/utils/portal.h | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/include/utils/portal.h b/src/include/utils/portal.h index b903cb0fbe1..b4a259dcf8f 100644 --- a/src/include/utils/portal.h +++ b/src/include/utils/portal.h @@ -147,6 +147,8 @@ typedef struct PortalData /* Status data */ PortalStatus status; /* see above */ bool portalPinned; /* a pinned portal can't be dropped */ + bool autoHeld; /* was automatically converted from pinned to + * held (see HoldPinnedPortals()) */ /* If not NULL, Executor is active; call ExecutorEnd eventually: */ QueryDesc *queryDesc; /* info needed for executor invocation */ @@ -204,6 +206,7 @@ extern void EnablePortalManager(void); extern bool PreCommit_Portals(bool isPrepare); extern void AtAbort_Portals(void); extern void AtCleanup_Portals(void); +extern void PortalErrorCleanup(void); extern void AtSubCommit_Portals(SubTransactionId mySubid, SubTransactionId parentSubid, ResourceOwner parentXactOwner); @@ -231,6 +234,6 @@ extern PlannedStmt *PortalGetPrimaryStmt(Portal portal); extern void PortalCreateHoldStore(Portal portal); extern void PortalHashTableDeleteAll(void); extern bool ThereAreNoReadyPortals(void); -extern bool ThereArePinnedPortals(void); +extern void HoldPinnedPortals(void); #endif /* PORTAL_H */ |