aboutsummaryrefslogtreecommitdiff
path: root/src/include/utils/xml.h
diff options
context:
space:
mode:
authorPeter Eisentraut <peter@eisentraut.org>2022-09-12 17:35:55 +0200
committerPeter Eisentraut <peter@eisentraut.org>2022-09-12 17:36:26 +0200
commit595836e99bf1ee6d43405b885fb69bb8c6d3ee23 (patch)
tree9af38bcdaab9e75913c66b29f30caf1f9f4e5409 /src/include/utils/xml.h
parent8cb2a22bbb2cf4212482ac15021ceaa2e9c52209 (diff)
downloadpostgresql-595836e99bf1ee6d43405b885fb69bb8c6d3ee23.tar.gz
postgresql-595836e99bf1ee6d43405b885fb69bb8c6d3ee23.zip
Convert *GetDatum() and DatumGet*() macros to inline functions
The previous macro implementations just cast the argument to a target type but did not check whether the input type was appropriate. The function implementation can do better type checking of the input type. Reviewed-by: Aleksander Alekseev <aleksander@timescale.com> Discussion: https://www.postgresql.org/message-id/flat/8528fb7e-0aa2-6b54-85fb-0c0886dbd6ed%40enterprisedb.com
Diffstat (limited to 'src/include/utils/xml.h')
-rw-r--r--src/include/utils/xml.h13
1 files changed, 11 insertions, 2 deletions
diff --git a/src/include/utils/xml.h b/src/include/utils/xml.h
index 6620a626191..c71174d2041 100644
--- a/src/include/utils/xml.h
+++ b/src/include/utils/xml.h
@@ -47,8 +47,17 @@ typedef enum
/* struct PgXmlErrorContext is private to xml.c */
typedef struct PgXmlErrorContext PgXmlErrorContext;
-#define DatumGetXmlP(X) ((xmltype *) PG_DETOAST_DATUM(X))
-#define XmlPGetDatum(X) PointerGetDatum(X)
+static inline xmltype *
+DatumGetXmlP(Datum X)
+{
+ return (xmltype *) PG_DETOAST_DATUM(X);
+}
+
+static inline Datum
+XmlPGetDatum(const xmltype *X)
+{
+ return PointerGetDatum(X);
+}
#define PG_GETARG_XML_P(n) DatumGetXmlP(PG_GETARG_DATUM(n))
#define PG_RETURN_XML_P(x) PG_RETURN_POINTER(x)