diff options
author | Tom Lane <tgl@sss.pgh.pa.us> | 2005-10-18 20:38:58 +0000 |
---|---|---|
committer | Tom Lane <tgl@sss.pgh.pa.us> | 2005-10-18 20:38:58 +0000 |
commit | 220f2a7d15adc6ca811a3cbe5fee79ce4904cd91 (patch) | |
tree | f71baba620e60bdc4fcff8b3a008590d17e5ede1 /src/include | |
parent | 800af89004f1a9e816b8df644c31b3fa2a247f92 (diff) | |
download | postgresql-220f2a7d15adc6ca811a3cbe5fee79ce4904cd91.tar.gz postgresql-220f2a7d15adc6ca811a3cbe5fee79ce4904cd91.zip |
Code review for regexp_replace patch. Improve documentation and comments,
fix problems with replacement-string backslashes that aren't followed by
one of the expected characters, avoid giving the impression that
replace_text_regexp() is meant to be called directly as a SQL function,
etc.
Diffstat (limited to 'src/include')
-rw-r--r-- | src/include/utils/builtins.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/include/utils/builtins.h b/src/include/utils/builtins.h index 469d993d04d..1ec358f3849 100644 --- a/src/include/utils/builtins.h +++ b/src/include/utils/builtins.h @@ -7,7 +7,7 @@ * Portions Copyright (c) 1996-2005, PostgreSQL Global Development Group * Portions Copyright (c) 1994, Regents of the University of California * - * $PostgreSQL: pgsql/src/include/utils/builtins.h,v 1.266 2005/10/15 02:49:46 momjian Exp $ + * $PostgreSQL: pgsql/src/include/utils/builtins.h,v 1.267 2005/10/18 20:38:58 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -593,7 +593,8 @@ extern List *textToQualifiedNameList(text *textval); extern bool SplitIdentifierString(char *rawstring, char separator, List **namelist); extern Datum replace_text(PG_FUNCTION_ARGS); -extern Datum replace_text_regexp(PG_FUNCTION_ARGS); +extern text *replace_text_regexp(text *src_text, void *regexp, + text *replace_text, bool glob); extern Datum split_text(PG_FUNCTION_ARGS); extern Datum text_to_array(PG_FUNCTION_ARGS); extern Datum array_to_text(PG_FUNCTION_ARGS); |