diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2008-11-11 18:13:54 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2008-11-11 18:13:54 +0000 |
| commit | 5aa70422df0ef37fcc995d63bb9a5113805c0f69 (patch) | |
| tree | bca11505d2890eaa41e8186b12d9ce5669096814 /src/include | |
| parent | 8f74153732c512baa498eb6c38244c0d3a09dff8 (diff) | |
| download | postgresql-5aa70422df0ef37fcc995d63bb9a5113805c0f69.tar.gz postgresql-5aa70422df0ef37fcc995d63bb9a5113805c0f69.zip | |
Get rid of adjust_appendrel_attr_needed(), which has been broken ever since
we extended the appendrel mechanism to support UNION ALL optimization. The
reason nobody noticed was that we are not actually using attr_needed data for
appendrel children; hence it seems more reasonable to rip it out than fix it.
Back-patch to 8.2 because an Assert failure is possible in corner cases.
Per examination of an example from Jim Nasby.
In HEAD, also get rid of AppendRelInfo.col_mappings, which is quite inadequate
to represent UNION ALL situations; depend entirely on translated_vars instead.
Diffstat (limited to 'src/include')
| -rw-r--r-- | src/include/optimizer/prep.h | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/src/include/optimizer/prep.h b/src/include/optimizer/prep.h index 544dc766e8c..fd031573916 100644 --- a/src/include/optimizer/prep.h +++ b/src/include/optimizer/prep.h @@ -7,7 +7,7 @@ * Portions Copyright (c) 1996-2006, PostgreSQL Global Development Group * Portions Copyright (c) 1994, Regents of the University of California * - * $PostgreSQL: pgsql/src/include/optimizer/prep.h,v 1.57 2006/10/04 00:30:09 momjian Exp $ + * $PostgreSQL: pgsql/src/include/optimizer/prep.h,v 1.57.2.1 2008/11/11 18:13:54 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -50,9 +50,4 @@ extern void expand_inherited_tables(PlannerInfo *root); extern Node *adjust_appendrel_attrs(Node *node, AppendRelInfo *appinfo); -extern Relids *adjust_appendrel_attr_needed(RelOptInfo *oldrel, - AppendRelInfo *appinfo, - AttrNumber new_min_attr, - AttrNumber new_max_attr); - #endif /* PREP_H */ |