diff options
| author | Robert Haas <rhaas@postgresql.org> | 2017-02-27 22:34:21 +0530 |
|---|---|---|
| committer | Robert Haas <rhaas@postgresql.org> | 2017-02-27 22:34:21 +0530 |
| commit | b0f18cb77f50a54e997d857d592f6a511617f52c (patch) | |
| tree | 7227b1f1de2b718d0ca66cd2779308ac4d5418ca /src/include | |
| parent | 817f2a586342767d3289a320bb1dac5dcbb76979 (diff) | |
| download | postgresql-b0f18cb77f50a54e997d857d592f6a511617f52c.tar.gz postgresql-b0f18cb77f50a54e997d857d592f6a511617f52c.zip | |
hash: Refactor bucket squeeze code.
In preparation for adding write-ahead logging to hash indexes,
refactor _hash_freeovflpage and _hash_squeezebucket so that all
related page modifications happen in a single section of code. The
previous coding assumed that it would be fine to move tuples one at a
time, and also that the various operations involved in freeing an
overflow page didn't necessarily all need to be done together, all
of which is true if you don't care about write-ahead logging.
Amit Kapila, with slight changes by me.
Diffstat (limited to 'src/include')
| -rw-r--r-- | src/include/access/hash.h | 7 | ||||
| -rw-r--r-- | src/include/storage/bufpage.h | 1 |
2 files changed, 6 insertions, 2 deletions
diff --git a/src/include/access/hash.h b/src/include/access/hash.h index 3bf587b1b70..5767deb0295 100644 --- a/src/include/access/hash.h +++ b/src/include/access/hash.h @@ -303,11 +303,14 @@ extern Datum hash_uint32(uint32 k); extern void _hash_doinsert(Relation rel, IndexTuple itup); extern OffsetNumber _hash_pgaddtup(Relation rel, Buffer buf, Size itemsize, IndexTuple itup); +extern void _hash_pgaddmultitup(Relation rel, Buffer buf, IndexTuple *itups, + OffsetNumber *itup_offsets, uint16 nitups); /* hashovfl.c */ extern Buffer _hash_addovflpage(Relation rel, Buffer metabuf, Buffer buf, bool retain_pin); -extern BlockNumber _hash_freeovflpage(Relation rel, Buffer ovflbuf, Buffer wbuf, - BufferAccessStrategy bstrategy); +extern BlockNumber _hash_freeovflpage(Relation rel, Buffer bucketbuf, Buffer ovflbuf, + Buffer wbuf, IndexTuple *itups, OffsetNumber *itup_offsets, + Size *tups_size, uint16 nitups, BufferAccessStrategy bstrategy); extern void _hash_initbitmap(Relation rel, HashMetaPage metap, BlockNumber blkno, ForkNumber forkNum); extern void _hash_squeezebucket(Relation rel, diff --git a/src/include/storage/bufpage.h b/src/include/storage/bufpage.h index 294f9cb85ac..e956dc33860 100644 --- a/src/include/storage/bufpage.h +++ b/src/include/storage/bufpage.h @@ -425,6 +425,7 @@ extern Page PageGetTempPageCopySpecial(Page page); extern void PageRestoreTempPage(Page tempPage, Page oldPage); extern void PageRepairFragmentation(Page page); extern Size PageGetFreeSpace(Page page); +extern Size PageGetFreeSpaceForMultipleTuples(Page page, int ntups); extern Size PageGetExactFreeSpace(Page page); extern Size PageGetHeapFreeSpace(Page page); extern void PageIndexTupleDelete(Page page, OffsetNumber offset); |