diff options
| author | Amit Kapila <akapila@postgresql.org> | 2025-01-31 10:27:35 +0530 |
|---|---|---|
| committer | Amit Kapila <akapila@postgresql.org> | 2025-01-31 10:27:35 +0530 |
| commit | f41d8468ddea34170fe19fdc17b5a247e7d3ac78 (patch) | |
| tree | 579d85e4ea52344a862f78b4725541fa5aa16d35 /src/include | |
| parent | a632cd354d35e1c3352061c375b4458876c9f10a (diff) | |
| download | postgresql-f41d8468ddea34170fe19fdc17b5a247e7d3ac78.tar.gz postgresql-f41d8468ddea34170fe19fdc17b5a247e7d3ac78.zip | |
Raise an error while trying to acquire an invalid slot.
Once a replication slot is invalidated, it cannot be altered or used to
fetch changes. However, a process could still acquire an invalid slot and
fail later.
For example, if a process acquires a logical slot that was invalidated due
to wal_removed, it will eventually fail in CreateDecodingContext() when
attempting to access the removed WAL. Similarly, for physical replication
slots, even if the slot is invalidated and invalidation_reason is set to
wal_removed, the walsender does not currently check for invalidation when
starting physical replication. Instead, replication starts, and an error
is only reported later while trying to access WAL. Similarly, we prohibit
modifying slot properties for invalid slots but give the error for the
same after acquiring the slot.
This patch improves error handling by detecting invalid slots earlier at
the time of slot acquisition which is the first step. This also helped in
unifying different ERROR messages at different places and gave a
consistent message for invalid slots. This means that the message for
invalid slots will change to a generic message.
This will also be helpful for future patches where we are planning to
invalidate slots due to more reasons like idle_timeout because we don't
have to modify multiple places in such cases and avoid the chances of
missing out on a particular place.
Author: Nisha Moond <nisha.moond412@gmail.com>
Author: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Reviewed-by: Vignesh C <vignesh21@gmail.com>
Reviewed-by: Peter Smith <smithpb2250@gmail.com>
Reviewed-by: Hayato Kuroda <kuroda.hayato@fujitsu.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Discussion: https://postgr.es/m/CABdArM6pBL5hPnSQ+5nEVMANcF4FCH7LQmgskXyiLY75TMnKpw@mail.gmail.com
Diffstat (limited to 'src/include')
| -rw-r--r-- | src/include/replication/slot.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/include/replication/slot.h b/src/include/replication/slot.h index bf62b36ad07..47ebdaecb6a 100644 --- a/src/include/replication/slot.h +++ b/src/include/replication/slot.h @@ -253,7 +253,8 @@ extern void ReplicationSlotDropAcquired(void); extern void ReplicationSlotAlter(const char *name, const bool *failover, const bool *two_phase); -extern void ReplicationSlotAcquire(const char *name, bool nowait); +extern void ReplicationSlotAcquire(const char *name, bool nowait, + bool error_if_invalid); extern void ReplicationSlotRelease(void); extern void ReplicationSlotCleanup(bool synced_only); extern void ReplicationSlotSave(void); |