diff options
| author | Richard Guo <rguo@postgresql.org> | 2025-05-15 17:09:04 +0900 |
|---|---|---|
| committer | Richard Guo <rguo@postgresql.org> | 2025-05-15 17:09:04 +0900 |
| commit | fe29b2a1dab2b3d81e6c350679b7d9b0e1c8c850 (patch) | |
| tree | d3178a4ad1e430730f13d6e5cc57356f5be5414a /src/test/regress/sql/xml.sql | |
| parent | 2c0ed86d393670c7054d051490063de771f1791e (diff) | |
| download | postgresql-fe29b2a1dab2b3d81e6c350679b7d9b0e1c8c850.tar.gz postgresql-fe29b2a1dab2b3d81e6c350679b7d9b0e1c8c850.zip | |
Fix Assert failure in XMLTABLE parser
In an XMLTABLE expression, columns can be marked NOT NULL, and the
parser internally fabricates an option named "is_not_null" to
represent this. However, the parser also allows users to specify
arbitrary option names. This creates a conflict: a user can
explicitly use "is_not_null" as an option name and assign it a
non-Boolean value, which violates internal assumptions and triggers an
assertion failure.
To fix, this patch checks whether a user-supplied name collides with
the internally reserved option name and raises an error if so.
Additionally, the internal name is renamed to "__pg__is_not_null" to
further reduce the risk of collision with user-defined names.
Reported-by: Евгений Горбанев <gorbanyoves@basealt.ru>
Author: Richard Guo <guofenglinux@gmail.com>
Reviewed-by: Alvaro Herrera <alvherre@kurilemu.de>
Discussion: https://postgr.es/m/6bac9886-65bf-4cec-96bd-e304159f28db@basealt.ru
Backpatch-through: 15
Diffstat (limited to 'src/test/regress/sql/xml.sql')
| -rw-r--r-- | src/test/regress/sql/xml.sql | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/test/regress/sql/xml.sql b/src/test/regress/sql/xml.sql index 4c3520ce898..0ea4f508837 100644 --- a/src/test/regress/sql/xml.sql +++ b/src/test/regress/sql/xml.sql @@ -435,6 +435,8 @@ EXPLAIN (COSTS OFF, VERBOSE) SELECT * FROM xmltableview1; -- errors SELECT * FROM XMLTABLE (ROW () PASSING null COLUMNS v1 timestamp) AS f (v1, v2); +SELECT * FROM XMLTABLE (ROW () PASSING null COLUMNS v1 timestamp __pg__is_not_null 1) AS f (v1); + -- XMLNAMESPACES tests SELECT * FROM XMLTABLE(XMLNAMESPACES('http://x.y' AS zz), '/zz:rows/zz:row' |