diff options
| author | Andrew Dunstan <andrew@dunslane.net> | 2018-05-27 09:08:42 -0400 |
|---|---|---|
| committer | Andrew Dunstan <andrew@dunslane.net> | 2018-05-27 09:08:42 -0400 |
| commit | 3a7cc727c7c502353dbb730a0db793abec4de44b (patch) | |
| tree | c140b2974559d0a13d98c132ae52f7d0992aff95 /src/test/ssl/ServerSetup.pm | |
| parent | 8a56ff484808e9c05df9656cf4244229e8c7960d (diff) | |
| download | postgresql-3a7cc727c7c502353dbb730a0db793abec4de44b.tar.gz postgresql-3a7cc727c7c502353dbb730a0db793abec4de44b.zip | |
Don't fall off the end of perl functions
This complies with the perlcritic policy
Subroutines::RequireFinalReturn, which is a severity 4 policy. Since we
only currently check at severity level 5, the policy is raised to that
level until we move to level 4 or lower, so that any new infringements
will be caught.
A small cosmetic piece of tidying of the pgperlcritic script is
included.
Mike Blackwell
Discussion: https://postgr.es/m/CAESHdJpfFm_9wQnQ3koY3c91FoRQsO-fh02za9R3OEMndOn84A@mail.gmail.com
Diffstat (limited to 'src/test/ssl/ServerSetup.pm')
| -rw-r--r-- | src/test/ssl/ServerSetup.pm | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/src/test/ssl/ServerSetup.pm b/src/test/ssl/ServerSetup.pm index ced279c31b9..1cd3badaa1d 100644 --- a/src/test/ssl/ServerSetup.pm +++ b/src/test/ssl/ServerSetup.pm @@ -47,6 +47,7 @@ sub test_connect_ok ]; command_ok($cmd, $test_name); + return; } sub test_connect_fails @@ -60,6 +61,7 @@ sub test_connect_fails ]; command_fails_like($cmd, $expected_stderr, $test_name); + return; } # Copy a set of files, taking into account wildcards @@ -75,6 +77,7 @@ sub copy_files copy($orig_file, "$dest/$base_file") or die "Could not copy $orig_file to $dest"; } + return; } sub configure_test_server_for_ssl @@ -130,6 +133,8 @@ sub configure_test_server_for_ssl # Change pg_hba after restart because hostssl requires ssl=on configure_hba_for_ssl($node, $serverhost, $authmethod); + + return; } # Change the configuration to use given server cert file, and reload @@ -150,6 +155,7 @@ sub switch_server_cert close $sslconf; $node->restart; + return; } sub configure_hba_for_ssl @@ -173,4 +179,7 @@ sub configure_hba_for_ssl print $hba "hostssl certdb all ::1/128 cert\n"; close $hba; + return; } + +1;
\ No newline at end of file |