diff options
| author | Noah Misch <noah@leadboat.com> | 2020-05-13 20:42:09 -0700 |
|---|---|---|
| committer | Noah Misch <noah@leadboat.com> | 2020-05-13 20:42:23 -0700 |
| commit | 7130be8aa3e022b08245f77cbbe5a71473b36a73 (patch) | |
| tree | 50ac3da0927906c0eb7d4ebf151d34188affada7 /src/test | |
| parent | 5060275aa8a1ead56e0a41308d7a43049a6cbe43 (diff) | |
| download | postgresql-7130be8aa3e022b08245f77cbbe5a71473b36a73.tar.gz postgresql-7130be8aa3e022b08245f77cbbe5a71473b36a73.zip | |
In successful pg_recvlogical, end PGRES_COPY_OUT cleanly.
pg_recvlogical merely called PQfinish(), so the backend sent messages
after the disconnect. When that caused EPIPE in internal_flush(),
before a LogicalConfirmReceivedLocation(), the next pg_recvlogical would
repeat already-acknowledged records. Whether or not the defect causes
EPIPE, post-disconnect messages could contain an ErrorResponse that the
user should see. One properly ends PGRES_COPY_OUT by repeating
PQgetCopyData() until it returns a negative value. Augment one of the
tests to cover the case of WAL past --endpos. Back-patch to v10, where
commit 7c030783a5bd07cadffc2a1018bc33119a4c7505 first appeared. Before
that commit, pg_recvlogical never reached PGRES_COPY_OUT.
Reported by Thomas Munro.
Discussion: https://postgr.es/m/CAEepm=1MzM2Z_xNe4foGwZ1a+MO_2S9oYDq3M5D11=JDU_+0Nw@mail.gmail.com
Diffstat (limited to 'src/test')
| -rw-r--r-- | src/test/recovery/t/006_logical_decoding.pl | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/src/test/recovery/t/006_logical_decoding.pl b/src/test/recovery/t/006_logical_decoding.pl index 0bcd1d0b59f..1334bf6a601 100644 --- a/src/test/recovery/t/006_logical_decoding.pl +++ b/src/test/recovery/t/006_logical_decoding.pl @@ -71,6 +71,11 @@ my $endpos = $node_master->safe_psql('postgres', ); print "waiting to replay $endpos\n"; +# Insert some rows after $endpos, which we won't read. +$node_master->safe_psql('postgres', + qq[INSERT INTO decoding_test(x,y) SELECT s, s::text FROM generate_series(5,50) s;] +); + my $stdout_recv = $node_master->pg_recvlogical_upto( 'postgres', 'test_slot', $endpos, 180, 'include-xids' => '0', @@ -89,7 +94,7 @@ $stdout_recv = $node_master->pg_recvlogical_upto( 'skip-empty-xacts' => '1'); chomp($stdout_recv); is($stdout_recv, '', - 'pg_recvlogical acknowledged changes, nothing pending on slot'); + 'pg_recvlogical acknowledged changes'); $node_master->safe_psql('postgres', 'CREATE DATABASE otherdb'); |