diff options
| author | Andrew Dunstan <andrew@dunslane.net> | 2018-05-27 09:08:42 -0400 |
|---|---|---|
| committer | Andrew Dunstan <andrew@dunslane.net> | 2018-05-27 09:08:42 -0400 |
| commit | 3a7cc727c7c502353dbb730a0db793abec4de44b (patch) | |
| tree | c140b2974559d0a13d98c132ae52f7d0992aff95 /src/tools/msvc/Solution.pm | |
| parent | 8a56ff484808e9c05df9656cf4244229e8c7960d (diff) | |
| download | postgresql-3a7cc727c7c502353dbb730a0db793abec4de44b.tar.gz postgresql-3a7cc727c7c502353dbb730a0db793abec4de44b.zip | |
Don't fall off the end of perl functions
This complies with the perlcritic policy
Subroutines::RequireFinalReturn, which is a severity 4 policy. Since we
only currently check at severity level 5, the policy is raised to that
level until we move to level 4 or lower, so that any new infringements
will be caught.
A small cosmetic piece of tidying of the pgperlcritic script is
included.
Mike Blackwell
Discussion: https://postgr.es/m/CAESHdJpfFm_9wQnQ3koY3c91FoRQsO-fh02za9R3OEMndOn84A@mail.gmail.com
Diffstat (limited to 'src/tools/msvc/Solution.pm')
| -rw-r--r-- | src/tools/msvc/Solution.pm | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/src/tools/msvc/Solution.pm b/src/tools/msvc/Solution.pm index a33e68eccf0..8f0b355fc0e 100644 --- a/src/tools/msvc/Solution.pm +++ b/src/tools/msvc/Solution.pm @@ -75,6 +75,7 @@ sub DeterminePlatform $? >> 8 == 0 or die "cl command not found"; $self->{platform} = ($output =~ /^\/favor:<.+AMD64/m) ? 'x64' : 'Win32'; print "Detected hardware platform: $self->{platform}\n"; + return; } # Return 1 if $oldfile is newer than $newfile, or if $newfile doesn't exist. @@ -112,6 +113,7 @@ sub copyFile } close($i); close($o); + return; } sub GenerateFiles @@ -533,6 +535,7 @@ EOF <!ENTITY majorversion "$self->{majorver}"> EOF close($o); + return; } sub GenerateDefFile @@ -555,6 +558,7 @@ sub GenerateDefFile close($of); close($if); } + return; } sub AddProject @@ -727,6 +731,7 @@ EOF EndGlobal EOF close($sln); + return; } sub GetFakeConfigure |