aboutsummaryrefslogtreecommitdiff
path: root/src/tutorial/advanced.source
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2019-02-09 19:45:38 -0500
committerTom Lane <tgl@sss.pgh.pa.us>2019-02-09 19:45:38 -0500
commit73668c590cf5c5719ac0d0481201fd4fd79454bb (patch)
treefab88db99cd1baa983ca2aa2bf88b4849b20819c /src/tutorial/advanced.source
parentdc0eb137fec20c4f2d168dfcb6bda001a27ad548 (diff)
downloadpostgresql-73668c590cf5c5719ac0d0481201fd4fd79454bb.tar.gz
postgresql-73668c590cf5c5719ac0d0481201fd4fd79454bb.zip
Repair unsafe/unportable snprintf usage in pg_restore.
warn_or_exit_horribly() was blithely passing a potentially-NULL string pointer to a %s format specifier. That works (at least to the extent of not crashing) on some platforms, but not all, and since we switched to our own snprintf.c it doesn't work for us anywhere. Of the three string fields being handled this way here, I think that only "owner" is supposed to be nullable ... but considering that this is error-reporting code, it has very little business assuming anything, so put in defenses for all three. Per a crash observed on buildfarm member crake and then reproduced here. Because of the portability aspect, back-patch to all supported versions.
Diffstat (limited to 'src/tutorial/advanced.source')
0 files changed, 0 insertions, 0 deletions