aboutsummaryrefslogtreecommitdiff
path: root/src/tutorial/basics.source
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2017-07-20 11:29:36 -0400
committerTom Lane <tgl@sss.pgh.pa.us>2017-07-20 11:29:36 -0400
commit41ada83774929c3bbb069a90f2aa3a8ac508e876 (patch)
treed1d3c566d2d593fd89ef545d6ff8168e229910ba /src/tutorial/basics.source
parent0e8448bbfd2de5bf17b3fd379e1d28a14f1e9b02 (diff)
downloadpostgresql-41ada83774929c3bbb069a90f2aa3a8ac508e876.tar.gz
postgresql-41ada83774929c3bbb069a90f2aa3a8ac508e876.zip
Fix dumping of outer joins with empty qual lists.
Normally, a JoinExpr would have empty "quals" only if it came from CROSS JOIN syntax. However, it's possible to get to this state by specifying NATURAL JOIN between two tables with no common column names, and there might be other ways too. The code previously printed no ON clause if "quals" was empty; that's right for CROSS JOIN but syntactically invalid if it's some type of outer join. Fix by printing ON TRUE in that case. This got broken by commit 2ffa740be, which stopped using NATURAL JOIN syntax in ruleutils output due to its brittleness in the face of column renamings. Back-patch to 9.3 where that commit appeared. Per report from Tushar Ahuja. Discussion: https://postgr.es/m/98b283cd-6dda-5d3f-f8ac-87db8c76a3da@enterprisedb.com
Diffstat (limited to 'src/tutorial/basics.source')
0 files changed, 0 insertions, 0 deletions