diff options
author | Nathan Bossart <nathan@postgresql.org> | 2023-10-16 12:42:17 -0500 |
---|---|---|
committer | Nathan Bossart <nathan@postgresql.org> | 2023-10-16 12:42:17 -0500 |
commit | d1c56ad37b9676df23cb12bdabfffce2a5fc01a7 (patch) | |
tree | 2a3b0000941b74022b27d76e404ca140dca43342 /src/tutorial/basics.source | |
parent | 08c1795c52b8504e2f5c148454db84f73aa02e40 (diff) | |
download | postgresql-d1c56ad37b9676df23cb12bdabfffce2a5fc01a7.tar.gz postgresql-d1c56ad37b9676df23cb12bdabfffce2a5fc01a7.zip |
Move extra code out of the Pre/PostRestoreCommand() section.
If SIGTERM is received within this section, the startup process
will immediately proc_exit() in the signal handler, so it is
inadvisable to include any more code than is required there (as
such code is unlikely to be compatible with doing proc_exit() in a
signal handler). This commit moves the code recently added to this
section (see 1b06d7bac9 and 7fed801135) to outside of the section.
This ensures that the startup process only calls proc_exit() in its
SIGTERM handler for the duration of the system() call, which is how
this code worked from v8.4 to v14.
Reported-by: Michael Paquier, Thomas Munro
Analyzed-by: Andres Freund
Suggested-by: Tom Lane
Reviewed-by: Michael Paquier, Robert Haas, Thomas Munro, Andres Freund
Discussion: https://postgr.es/m/Y9nGDSgIm83FHcad%40paquier.xyz
Discussion: https://postgr.es/m/20230223231503.GA743455%40nathanxps13
Backpatch-through: 15
Diffstat (limited to 'src/tutorial/basics.source')
0 files changed, 0 insertions, 0 deletions