diff options
| author | Fujii Masao <fujii@postgresql.org> | 2020-06-25 11:13:13 +0900 |
|---|---|---|
| committer | Fujii Masao <fujii@postgresql.org> | 2020-06-25 11:14:31 +0900 |
| commit | 126c8fcec790652dd0cb755fdeedf2c02c8d8079 (patch) | |
| tree | 012a3fcea0c3a3b4a3a491bd1b69bb3722032501 /src/tutorial/funcs.c | |
| parent | 086bef8ac8b3635e7af94ac41e92dfc016b87e90 (diff) | |
| download | postgresql-126c8fcec790652dd0cb755fdeedf2c02c8d8079.tar.gz postgresql-126c8fcec790652dd0cb755fdeedf2c02c8d8079.zip | |
Remove erroneous assertion from pg_copy_logical_replication_slot().
If restart_lsn of logical replication slot gets behind more than
max_slot_wal_keep_size from the current LSN, the logical replication slot
would be invalidated and its restart_lsn is reset to an invalid LSN.
If this logical replication slot with an invalid restart_lsn was specified as
the source slot in pg_copy_logical_replication_slot(), the function caused
the assertion failure unexpectedly.
This assertion was added because restart_lsn should not be invalid before.
But in v13, it can be invalid thanks to max_slot_wal_keep_size. So since this
assertion is no longer useful, this commit removes it.
This commit also changes the errcode in the error message that
pg_copy_logical_replication_slot() emits when the slot with an invalid
restart_lsn is specified, to more appropriate one.
Back-patch to v13 where max_slot_wal_keep_size was added and
the assertion was no longer valid.
Author: Fujii Masao
Reviewed-by: Alvaro Herrera, Kyotaro Horiguchi
Discussion: https://postgr.es/m/f91de4fb-a7ab-b90e-8132-74796e049d51@oss.nttdata.com
Diffstat (limited to 'src/tutorial/funcs.c')
0 files changed, 0 insertions, 0 deletions