diff options
| author | Thomas Munro <tmunro@postgresql.org> | 2024-08-31 17:27:38 +1200 |
|---|---|---|
| committer | Thomas Munro <tmunro@postgresql.org> | 2024-08-31 17:28:02 +1200 |
| commit | 4effd0844daf41a962c05188b719df75ca8ced93 (patch) | |
| tree | 250b505dc16095537f7a266e9ff31ece26a4c730 /src/tutorial/funcs.c | |
| parent | ecd56459cfe40d3a494844dffc8cb999364df442 (diff) | |
| download | postgresql-4effd0844daf41a962c05188b719df75ca8ced93.tar.gz postgresql-4effd0844daf41a962c05188b719df75ca8ced93.zip | |
Fix unfairness in all-cached parallel seq scan.
Commit b5a9b18c introduced block streaming infrastructure with a special
fast path for all-cached scans, and commit b7b0f3f2 connected the
infrastructure up to sequential scans. One of the fast path
micro-optimizations had an unintended consequence: it interfered with
parallel sequential scan's block range allocator (from commit 56788d21),
which has its own ramp-up and ramp-down algorithm when handing out
groups of pages to workers. A scan of an all-cached table could give
extra blocks to one worker, when others had finished. In some plans
(probably already very bad plans, such as the one reported by
Alexander), the unfairness could be magnified.
An internal buffer of 16 block numbers is removed, keeping just a single
block buffer for technical reasons.
Back-patch to 17.
Reported-by: Alexander Lakhin <exclusion@gmail.com>
Discussion: https://postgr.es/m/63a63690-dd92-c809-0b47-af05459e95d1%40gmail.com
Diffstat (limited to 'src/tutorial/funcs.c')
0 files changed, 0 insertions, 0 deletions