diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2013-10-28 10:28:35 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2013-10-28 10:30:10 -0400 |
| commit | 01c1b1aa25149674f9347f9d915533a53c33eff6 (patch) | |
| tree | 037b2d71e30f711a06d5e708fc05b757b38ed2f0 /src | |
| parent | bb604d03abf1402764d384acb1ae36d379965126 (diff) | |
| download | postgresql-01c1b1aa25149674f9347f9d915533a53c33eff6.tar.gz postgresql-01c1b1aa25149674f9347f9d915533a53c33eff6.zip | |
Improve documentation about usage of FDW validator functions.
SGML documentation, as well as code comments, failed to note that an FDW's
validator will be applied to foreign-table options for foreign tables using
the FDW.
Etsuro Fujita
Diffstat (limited to 'src')
| -rw-r--r-- | src/backend/commands/foreigncmds.c | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/src/backend/commands/foreigncmds.c b/src/backend/commands/foreigncmds.c index fb311185c8b..056bcae8a10 100644 --- a/src/backend/commands/foreigncmds.c +++ b/src/backend/commands/foreigncmds.c @@ -39,7 +39,9 @@ /* * Convert a DefElem list to the text array format that is used in - * pg_foreign_data_wrapper, pg_foreign_server, and pg_user_mapping. + * pg_foreign_data_wrapper, pg_foreign_server, pg_user_mapping, and + * pg_foreign_table. + * * Returns the array in the form of a Datum, or PointerGetDatum(NULL) * if the list is empty. * @@ -88,7 +90,8 @@ optionListToArray(List *options) * Returns the array in the form of a Datum, or PointerGetDatum(NULL) * if the list is empty. * - * This is used by CREATE/ALTER of FOREIGN DATA WRAPPER/SERVER/USER MAPPING. + * This is used by CREATE/ALTER of FOREIGN DATA WRAPPER/SERVER/USER MAPPING/ + * FOREIGN TABLE. */ Datum transformGenericOptions(Oid catalogId, @@ -681,8 +684,9 @@ AlterForeignDataWrapper(AlterFdwStmt *stmt) repl_repl[Anum_pg_foreign_data_wrapper_fdwvalidator - 1] = true; /* - * It could be that the options for the FDW, SERVER and USER MAPPING - * are no longer valid with the new validator. Warn about this. + * It could be that existing options for the FDW or dependent SERVER, + * USER MAPPING or FOREIGN TABLE objects are no longer valid according + * to the new validator. Warn about this. */ if (OidIsValid(fdwvalidator)) ereport(WARNING, |