aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorDavid Rowley <drowley@postgresql.org>2020-06-13 11:28:12 +1200
committerDavid Rowley <drowley@postgresql.org>2020-06-13 11:28:12 +1200
commit095f2d95c92704747d84d499a33b527af42bb08e (patch)
tree551194cee63a310cf46910f2d709f5171820bc2b /src
parent44eff28410598ef86d3d8bd812439aabf19f7ee0 (diff)
downloadpostgresql-095f2d95c92704747d84d499a33b527af42bb08e.tar.gz
postgresql-095f2d95c92704747d84d499a33b527af42bb08e.zip
Add missing extern keyword for a couple of numutils functions
In passing, also remove a few surplus empty lines from pg_ltoa and pg_ulltoa_n in numutils.c Reported-by: Andrew Gierth Discussion: https://postgr.es/m/87y2ou3xuh.fsf@news-spur.riddles.org.uk Backpatch-through: 13, where these changes were introduced
Diffstat (limited to 'src')
-rw-r--r--src/backend/utils/adt/numutils.c2
-rw-r--r--src/include/utils/builtins.h4
2 files changed, 2 insertions, 4 deletions
diff --git a/src/backend/utils/adt/numutils.c b/src/backend/utils/adt/numutils.c
index 13877fdc1d1..a9d3fbf758f 100644
--- a/src/backend/utils/adt/numutils.c
+++ b/src/backend/utils/adt/numutils.c
@@ -413,7 +413,6 @@ pg_ultoa_n(uint32 value, char *a)
void
pg_ltoa(int32 value, char *a)
{
-
uint32 uvalue = (uint32) value;
int len;
@@ -437,7 +436,6 @@ pg_ulltoa_n(uint64 value, char *a)
i = 0;
uint32 value2;
-
/* Degenerate case */
if (value == 0)
{
diff --git a/src/include/utils/builtins.h b/src/include/utils/builtins.h
index a352a8b773c..a5c8772e95f 100644
--- a/src/include/utils/builtins.h
+++ b/src/include/utils/builtins.h
@@ -48,8 +48,8 @@ extern int32 pg_atoi(const char *s, int size, int c);
extern int16 pg_strtoint16(const char *s);
extern int32 pg_strtoint32(const char *s);
extern void pg_itoa(int16 i, char *a);
-int pg_ultoa_n(uint32 l, char *a);
-int pg_ulltoa_n(uint64 l, char *a);
+extern int pg_ultoa_n(uint32 l, char *a);
+extern int pg_ulltoa_n(uint64 l, char *a);
extern void pg_ltoa(int32 l, char *a);
extern void pg_lltoa(int64 ll, char *a);
extern char *pg_ultostr_zeropad(char *str, uint32 value, int32 minwidth);