diff options
| author | Andrew Dunstan <andrew@dunslane.net> | 2023-07-03 10:06:26 -0400 |
|---|---|---|
| committer | Andrew Dunstan <andrew@dunslane.net> | 2023-07-03 10:09:12 -0400 |
| commit | 16152705b31d12c339e3a9ee44ed43972a6ee96c (patch) | |
| tree | 34109c00a4731d2b129687afc01b519932606a2d /src | |
| parent | c24e9ef330ac7da1d1628d21b2d5defb0ec03c54 (diff) | |
| download | postgresql-16152705b31d12c339e3a9ee44ed43972a6ee96c.tar.gz postgresql-16152705b31d12c339e3a9ee44ed43972a6ee96c.zip | |
Improve pg_basebackup long file name test Windows robustness
Creation of a file with a very long name can create problems on Windows
due to its file path limits. Work around that by creating the file via a
symlink with a shorter name.
Error displayed by buildfarm animal fairywren.o
Backpatch to all live branches
Diffstat (limited to 'src')
| -rw-r--r-- | src/bin/pg_basebackup/t/010_pg_basebackup.pl | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/src/bin/pg_basebackup/t/010_pg_basebackup.pl b/src/bin/pg_basebackup/t/010_pg_basebackup.pl index 793d64863c7..e0009c85315 100644 --- a/src/bin/pg_basebackup/t/010_pg_basebackup.pl +++ b/src/bin/pg_basebackup/t/010_pg_basebackup.pl @@ -311,8 +311,12 @@ $node->command_fails( '-T with invalid format fails'); # Tar format doesn't support filenames longer than 100 bytes. +# Create the test file via a short name directory so it doesn't blow the +# Windows path limit. +my $lftmp = PostgreSQL::Test::Utils::tempdir_short; +dir_symlink "$pgdata", "$lftmp/pgdata"; my $superlongname = "superlongname_" . ("x" x 100); -my $superlongpath = "$pgdata/$superlongname"; +my $superlongpath = "$lftmp/pgdata/$superlongname"; open my $file, '>', "$superlongpath" or die "unable to create file $superlongpath"; @@ -320,7 +324,7 @@ close $file; $node->command_fails( [ @pg_basebackup_defs, '-D', "$tempdir/tarbackup_l1", '-Ft' ], 'pg_basebackup tar with long name fails'); -unlink "$pgdata/$superlongname"; +unlink "$superlongpath"; # The following tests are for symlinks. |