diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2018-05-21 00:32:28 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2018-05-21 00:32:39 -0400 |
| commit | 28782d7e3b923a9eb9e1063c6e3cc69e167fad11 (patch) | |
| tree | e66b38c5d74740628f599b4f1dead148df275d18 /src | |
| parent | fa2cfb962c05df730f6bf586614eb39a4b0b5238 (diff) | |
| download | postgresql-28782d7e3b923a9eb9e1063c6e3cc69e167fad11.tar.gz postgresql-28782d7e3b923a9eb9e1063c6e3cc69e167fad11.zip | |
Fix unsafe usage of strerror(errno) within ereport().
This is the converse of the unsafe-usage-of-%m problem: the reason
ereport/elog provide that format code is mainly to dodge the hazard
of errno getting changed before control reaches functions within the
arguments of the macro. I only found one instance of this hazard,
but it's been there since 9.4 :-(.
Diffstat (limited to 'src')
| -rw-r--r-- | src/backend/libpq/auth.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/backend/libpq/auth.c b/src/backend/libpq/auth.c index 10e92b458e1..1907f88bc18 100644 --- a/src/backend/libpq/auth.c +++ b/src/backend/libpq/auth.c @@ -2017,10 +2017,12 @@ auth_peer(hbaPort *port) pw = getpwuid(uid); if (!pw) { + int save_errno = errno; + ereport(LOG, (errmsg("could not look up local user ID %ld: %s", (long) uid, - errno ? strerror(errno) : _("user does not exist")))); + save_errno ? strerror(save_errno) : _("user does not exist")))); return STATUS_ERROR; } |