diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2021-12-15 18:44:47 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2021-12-15 18:44:47 -0500 |
| commit | 2a712066d0587f65fcecd44e884dc6a09958dbdd (patch) | |
| tree | 7b6c5d0c16cf390f509bd9b3efb81ec1d400795a /src | |
| parent | bf9a55c10729988a3c7ffbe14108e29d90283939 (diff) | |
| download | postgresql-2a712066d0587f65fcecd44e884dc6a09958dbdd.tar.gz postgresql-2a712066d0587f65fcecd44e884dc6a09958dbdd.zip | |
Remove pg_dump's --no-synchronized-snapshots switch.
Server versions for which there was a plausible reason to
use this switch are all out of support now. Leaving it
around would accomplish little except to let careless DBAs
shoot themselves in the foot.
Discussion: https://postgr.es/m/556122.1639520324@sss.pgh.pa.us
Diffstat (limited to 'src')
| -rw-r--r-- | src/bin/pg_dump/pg_backup.h | 1 | ||||
| -rw-r--r-- | src/bin/pg_dump/pg_dump.c | 11 |
2 files changed, 2 insertions, 10 deletions
diff --git a/src/bin/pg_dump/pg_backup.h b/src/bin/pg_dump/pg_backup.h index d3aac0dbdf8..753252e05e0 100644 --- a/src/bin/pg_dump/pg_backup.h +++ b/src/bin/pg_dump/pg_backup.h @@ -175,7 +175,6 @@ typedef struct _dumpOptions int no_security_labels; int no_publications; int no_subscriptions; - int no_synchronized_snapshots; int no_toast_compression; int no_unlogged_table_data; int serializable_deferrable; diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c index 326441a76a0..15dae8bd88e 100644 --- a/src/bin/pg_dump/pg_dump.c +++ b/src/bin/pg_dump/pg_dump.c @@ -394,7 +394,6 @@ main(int argc, char **argv) {"no-publications", no_argument, &dopt.no_publications, 1}, {"no-security-labels", no_argument, &dopt.no_security_labels, 1}, {"no-subscriptions", no_argument, &dopt.no_subscriptions, 1}, - {"no-synchronized-snapshots", no_argument, &dopt.no_synchronized_snapshots, 1}, {"no-toast-compression", no_argument, &dopt.no_toast_compression, 1}, {"no-unlogged-table-data", no_argument, &dopt.no_unlogged_table_data, 1}, {"no-sync", no_argument, NULL, 7}, @@ -1029,7 +1028,6 @@ help(const char *progname) printf(_(" --no-publications do not dump publications\n")); printf(_(" --no-security-labels do not dump security label assignments\n")); printf(_(" --no-subscriptions do not dump subscriptions\n")); - printf(_(" --no-synchronized-snapshots do not use synchronized snapshots in parallel jobs\n")); printf(_(" --no-tablespaces do not dump tablespace assignments\n")); printf(_(" --no-toast-compression do not dump TOAST compression methods\n")); printf(_(" --no-unlogged-table-data do not dump unlogged table data\n")); @@ -1211,15 +1209,10 @@ setup_connection(Archive *AH, const char *dumpencoding, ExecuteSqlStatement(AH, query->data); destroyPQExpBuffer(query); } - else if (AH->numWorkers > 1 && - !dopt->no_synchronized_snapshots) + else if (AH->numWorkers > 1) { if (AH->isStandby && AH->remoteVersion < 100000) - fatal("Synchronized snapshots on standby servers are not supported by this server version.\n" - "Run with --no-synchronized-snapshots instead if you do not need\n" - "synchronized snapshots."); - - + fatal("parallel dumps from standby servers are not supported by this server version"); AH->sync_snapshot_id = get_synchronized_snapshot(AH); } } |