diff options
| author | Andres Freund <andres@anarazel.de> | 2015-02-03 23:52:15 +0100 |
|---|---|---|
| committer | Andres Freund <andres@anarazel.de> | 2015-02-03 23:52:15 +0100 |
| commit | 3a54f4a4944b849846c5a1494810ea06bd6601b7 (patch) | |
| tree | a58e11642d8e9acad5afa4fdd842d53352d8650c /src | |
| parent | 2505ce0be0b686c5a0a5141e9d080e7fdc35988a (diff) | |
| download | postgresql-3a54f4a4944b849846c5a1494810ea06bd6601b7.tar.gz postgresql-3a54f4a4944b849846c5a1494810ea06bd6601b7.zip | |
Remove ill-conceived Assertion in ProcessClientWriteInterrupt().
It's perfectly fine to have blocked interrupts when
ProcessClientWriteInterrupt() is called. In fact it's commonly the
case when emitting error reports. And we deal with that correctly.
Even if that'd not be the case, it'd be a bad location for such a
assertion. Because ProcessClientWriteInterrupt() is only called when
the socket is blocked it's hard to hit.
Per Heikki and buildfarm animals nightjar and dunlin.
Diffstat (limited to 'src')
| -rw-r--r-- | src/backend/tcop/postgres.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/backend/tcop/postgres.c b/src/backend/tcop/postgres.c index f2a426d792a..28af40c3dc6 100644 --- a/src/backend/tcop/postgres.c +++ b/src/backend/tcop/postgres.c @@ -571,8 +571,6 @@ ProcessClientWriteInterrupt(bool blocked) { int save_errno = errno; - Assert(InterruptHoldoffCount == 0 && CritSectionCount == 0); - /* * We only want to process the interrupt here if socket writes are * blocking to increase the chance to get an error message to the |