diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2020-08-09 12:39:08 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2020-08-09 12:39:08 -0400 |
| commit | 418414daaa4fc4e88f84c6c456bd0ac1c4c86efd (patch) | |
| tree | aa7c87d4d6ccb6cc0264958bbd63f27245de2c86 /src | |
| parent | 65a6769152f4e523e41a9a72f4b332cf427cec90 (diff) | |
| download | postgresql-418414daaa4fc4e88f84c6c456bd0ac1c4c86efd.tar.gz postgresql-418414daaa4fc4e88f84c6c456bd0ac1c4c86efd.zip | |
Check for fseeko() failure in pg_dump's _tarAddFile().
Coverity pointed out, not unreasonably, that we checked fseeko's
result at every other call site but these. Failure to seek in the
temp file (note this is NOT pg_dump's output file) seems quite
unlikely, and even if it did happen the file length cross-check
further down would probably detect the problem. Still, that's a
poor excuse for not checking the result of a system call.
Diffstat (limited to 'src')
| -rw-r--r-- | src/bin/pg_dump/pg_backup_tar.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/bin/pg_dump/pg_backup_tar.c b/src/bin/pg_dump/pg_backup_tar.c index 0e547e83be8..a6acd85f60f 100644 --- a/src/bin/pg_dump/pg_backup_tar.c +++ b/src/bin/pg_dump/pg_backup_tar.c @@ -1085,11 +1085,13 @@ _tarAddFile(ArchiveHandle *AH, TAR_MEMBER *th) /* * Find file len & go back to start. */ - fseeko(tmp, 0, SEEK_END); + if (fseeko(tmp, 0, SEEK_END) != 0) + fatal("error during file seek: %m"); th->fileLen = ftello(tmp); if (th->fileLen < 0) fatal("could not determine seek position in archive file: %m"); - fseeko(tmp, 0, SEEK_SET); + if (fseeko(tmp, 0, SEEK_SET) != 0) + fatal("error during file seek: %m"); _tarWriteHeader(th); |