diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2016-08-24 22:20:01 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2016-08-24 22:20:01 -0400 |
| commit | 46bd14a108ffde3e0db68ccae0fd88a4128c8e84 (patch) | |
| tree | 4d8a1ad959b55b04f61d8abefa3c5f594e7d8e4e /src | |
| parent | 25fe5f758c10c52b96497b04658382c2bb577e8f (diff) | |
| download | postgresql-46bd14a108ffde3e0db68ccae0fd88a4128c8e84.tar.gz postgresql-46bd14a108ffde3e0db68ccae0fd88a4128c8e84.zip | |
Fix small query-lifespan memory leak in bulk updates.
When there is an identifiable REPLICA IDENTITY index on the target table,
heap_update leaks the id_attrs bitmapset. That's not many bytes, but it
adds up over enough rows, since the code typically runs in a query-lifespan
context. Bug introduced in commit e55704d8b, which did a rather poor job
of cloning the existing use-pattern for RelationGetIndexAttrBitmap().
Per bug #14293 from Zhou Digoal. Back-patch to 9.4 where the bug was
introduced.
Report: <20160824114320.15676.45171@wrigleys.postgresql.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/backend/access/heap/heapam.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c index ee2dd57ec64..b8f4fe570ac 100644 --- a/src/backend/access/heap/heapam.c +++ b/src/backend/access/heap/heapam.c @@ -3579,6 +3579,7 @@ l2: ReleaseBuffer(vmbuffer); bms_free(hot_attrs); bms_free(key_attrs); + bms_free(id_attrs); return result; } @@ -4031,6 +4032,7 @@ l2: bms_free(hot_attrs); bms_free(key_attrs); + bms_free(id_attrs); return HeapTupleMayBeUpdated; } |