diff options
author | Tom Lane <tgl@sss.pgh.pa.us> | 2007-08-21 16:08:23 +0000 |
---|---|---|
committer | Tom Lane <tgl@sss.pgh.pa.us> | 2007-08-21 16:08:23 +0000 |
commit | 5c681ab1cbd057b0617e8bf5b862904bb460eee6 (patch) | |
tree | bb1af65c3ca6edd2580eecc822e8990f55590dad /src | |
parent | 1c36de33b0084896c9e39fa9a2d8c05be54979ea (diff) | |
download | postgresql-5c681ab1cbd057b0617e8bf5b862904bb460eee6.tar.gz postgresql-5c681ab1cbd057b0617e8bf5b862904bb460eee6.zip |
Exclude snowball/libstemmer/ files from the set processed by pgindent.
There's not much point in prettifying machine-generated code, and it
seems best to keep these files exactly like upstream anyway. Also add
some notes about why various files are excluded.
Diffstat (limited to 'src')
-rw-r--r-- | src/tools/pgindent/README | 14 |
1 files changed, 13 insertions, 1 deletions
diff --git a/src/tools/pgindent/README b/src/tools/pgindent/README index 6fdff4ee678..3610d46a93f 100644 --- a/src/tools/pgindent/README +++ b/src/tools/pgindent/README @@ -12,7 +12,7 @@ symbols. From the top directory, run: find . -name '*.[ch]' -type f -print | - egrep -v '/s_lock.h|src/interfaces/ecpg/test/expected/' | + egrep -v '/s_lock.h|/ecpg/test/expected/|/snowball/libstemmer/' | xargs -n100 pgindent We have standardized on NetBSD's indent. We have fixed a few bugs which @@ -24,3 +24,15 @@ These bugs become pretty major when you are doing >500k lines of code. If you don't believe me, take a directory and make a copy. Run pgindent on the copy using GNU indent, and do a diff -r. You will see what I mean. GNU indent does some things better, but mangles too. + +Notes about excluded files: + +src/include/storage/s_lock.h is excluded because it contains assembly code +that pgindent tends to mess up. + +src/interfaces/ecpg/test/expected/ is excluded to avoid breaking the ecpg +regression tests. + +src/include/snowball/libstemmer/ and src/backend/snowball/libstemmer/ +are excluded because those files are imported from an external project, +not maintained locally, and are machine-generated anyway. |