diff options
| author | Andrew Dunstan <andrew@dunslane.net> | 2019-03-01 11:38:54 -0500 |
|---|---|---|
| committer | Andrew Dunstan <andrew@dunslane.net> | 2019-03-01 11:38:54 -0500 |
| commit | 6cbdbd9e8d8f2986fde44f2431ed8d0c8fce7f5d (patch) | |
| tree | 9f490874e04f8cb24923791d6f14a53e9b55b770 /src | |
| parent | f092de0503cd77a8463e7089c249d5e0586a120b (diff) | |
| download | postgresql-6cbdbd9e8d8f2986fde44f2431ed8d0c8fce7f5d.tar.gz postgresql-6cbdbd9e8d8f2986fde44f2431ed8d0c8fce7f5d.zip | |
Add extra descriptive headings in pg_dumpall
Headings are added for the User Configurations and Databases sections,
and for each user configuration and database in the output.
Author: Fabien Coelho
Discussion: https://postgr.es/m/alpine.DEB.2.21.1812272222130.32444@lancre
Diffstat (limited to 'src')
| -rw-r--r-- | src/bin/pg_dump/pg_dumpall.c | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/src/bin/pg_dump/pg_dumpall.c b/src/bin/pg_dump/pg_dumpall.c index 773bbdd04c1..a86965e6702 100644 --- a/src/bin/pg_dump/pg_dumpall.c +++ b/src/bin/pg_dump/pg_dumpall.c @@ -1346,6 +1346,7 @@ dumpUserConfig(PGconn *conn, const char *username) { PQExpBuffer buf = createPQExpBuffer(); int count = 1; + bool first = true; for (;;) { @@ -1367,6 +1368,14 @@ dumpUserConfig(PGconn *conn, const char *username) if (PQntuples(res) == 1 && !PQgetisnull(res, 0, 0)) { + /* comment at section start, only if needed */ + if (first) + { + fprintf(OPF, "--\n-- User Configurations\n--\n\n"); + first = false; + } + + fprintf(OPF, "--\n-- User Config \"%s\"\n--\n\n", username); resetPQExpBuffer(buf); makeAlterConfigCommand(conn, PQgetvalue(res, 0, 0), "ROLE", username, NULL, NULL, @@ -1454,6 +1463,9 @@ dumpDatabases(PGconn *conn) "WHERE datallowconn " "ORDER BY (datname <> 'template1'), datname"); + if (PQntuples(res) > 0) + fprintf(OPF, "--\n-- Databases\n--\n\n"); + for (i = 0; i < PQntuples(res); i++) { char *dbname = PQgetvalue(res, i, 0); @@ -1476,6 +1488,8 @@ dumpDatabases(PGconn *conn) if (verbose) fprintf(stderr, _("%s: dumping database \"%s\"...\n"), progname, dbname); + fprintf(OPF, "--\n-- Database \"%s\" dump\n--\n\n", dbname); + /* * We assume that "template1" and "postgres" already exist in the * target installation. dropDBs() won't have removed them, for fear |