aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorRobert Haas <rhaas@postgresql.org>2021-03-12 14:55:40 -0500
committerRobert Haas <rhaas@postgresql.org>2021-03-12 14:55:40 -0500
commit7a1527c02c147a4107490662cb1872524c54a8ae (patch)
tree32866b8d252f802fbab81f65d177d292a7fe594c /src
parentd60e61de4fb4a8e7ca88204c2c409e7380887d76 (diff)
downloadpostgresql-7a1527c02c147a4107490662cb1872524c54a8ae.tar.gz
postgresql-7a1527c02c147a4107490662cb1872524c54a8ae.zip
Adjust perl style.
Per buildfarm member crake.
Diffstat (limited to 'src')
-rw-r--r--src/bin/pg_amcheck/t/003_check.pl13
-rw-r--r--src/bin/pg_amcheck/t/004_verify_heapam.pl4
2 files changed, 8 insertions, 9 deletions
diff --git a/src/bin/pg_amcheck/t/003_check.pl b/src/bin/pg_amcheck/t/003_check.pl
index e43ffe7ed6f..620634875e6 100644
--- a/src/bin/pg_amcheck/t/003_check.pl
+++ b/src/bin/pg_amcheck/t/003_check.pl
@@ -10,7 +10,7 @@ my ($node, $port, %corrupt_page, %remove_relation);
# Returns the filesystem path for the named relation.
#
# Assumes the test node is running
-sub relation_filepath($$)
+sub relation_filepath
{
my ($dbname, $relname) = @_;
@@ -24,7 +24,7 @@ sub relation_filepath($$)
# Returns the name of the toast relation associated with the named relation.
#
# Assumes the test node is running
-sub relation_toast($$)
+sub relation_toast
{
my ($dbname, $relname) = @_;
@@ -34,7 +34,6 @@ sub relation_toast($$)
WHERE c.oid = '$relname'::regclass
AND c.reltoastrelid != 0
));
- return undef unless defined $rel;
return $rel;
}
@@ -42,7 +41,7 @@ sub relation_toast($$)
# to be corrupted by means of overwriting junk in the first page.
#
# Assumes the test node is running.
-sub plan_to_corrupt_first_page($$)
+sub plan_to_corrupt_first_page
{
my ($dbname, $relname) = @_;
my $relpath = relation_filepath($dbname, $relname);
@@ -53,7 +52,7 @@ sub plan_to_corrupt_first_page($$)
# to be corrupted by means of removing the file..
#
# Assumes the test node is running
-sub plan_to_remove_relation_file($$)
+sub plan_to_remove_relation_file
{
my ($dbname, $relname) = @_;
my $relpath = relation_filepath($dbname, $relname);
@@ -65,7 +64,7 @@ sub plan_to_remove_relation_file($$)
# corrupted by means of removing the file.
#
# Assumes the test node is running.
-sub plan_to_remove_toast_file($$)
+sub plan_to_remove_toast_file
{
my ($dbname, $relname) = @_;
my $toastname = relation_toast($dbname, $relname);
@@ -73,7 +72,7 @@ sub plan_to_remove_toast_file($$)
}
# Corrupts the first page of the given file path
-sub corrupt_first_page($)
+sub corrupt_first_page
{
my ($relpath) = @_;
diff --git a/src/bin/pg_amcheck/t/004_verify_heapam.pl b/src/bin/pg_amcheck/t/004_verify_heapam.pl
index 48dfbef1452..5ed119f0468 100644
--- a/src/bin/pg_amcheck/t/004_verify_heapam.pl
+++ b/src/bin/pg_amcheck/t/004_verify_heapam.pl
@@ -92,7 +92,7 @@ use constant HEAPTUPLE_PACK_LENGTH => 58; # Total size
# perl hash with named fields. These fields exactly match the ones understood
# by write_tuple(), below. Returns a reference to this hash.
#
-sub read_tuple ($$)
+sub read_tuple
{
my ($fh, $offset) = @_;
my ($buffer, %tup);
@@ -145,7 +145,7 @@ sub read_tuple ($$)
# subset of fields modified. The function does no error checking. Use
# cautiously.
#
-sub write_tuple($$$)
+sub write_tuple
{
my ($fh, $offset, $tup) = @_;
my $buffer = pack(HEAPTUPLE_PACK_CODE,