diff options
| author | Stephen Frost <sfrost@snowman.net> | 2013-07-14 21:17:59 -0400 |
|---|---|---|
| committer | Stephen Frost <sfrost@snowman.net> | 2013-07-14 21:21:15 -0400 |
| commit | 8126bfb5b5f0b413455edd23ff3bf08d83f1cddc (patch) | |
| tree | 54211d81d641bc887cd7064426e9c17b9bba9d9e /src | |
| parent | b68a1fc7ff1a50a7282e8edff7c51333274c3334 (diff) | |
| download | postgresql-8126bfb5b5f0b413455edd23ff3bf08d83f1cddc.tar.gz postgresql-8126bfb5b5f0b413455edd23ff3bf08d83f1cddc.zip | |
Check version before allocating PQExpBuffer
In pg_dump.c:getEventTriggers, check what major version we are on
before calling createPQExpBuffer() to avoid leaking that bit of
memory.
Leak discovered by the Coverity scanner.
Back-patch to 9.3 where support for dumping event triggers was
added.
Diffstat (limited to 'src')
| -rw-r--r-- | src/bin/pg_dump/pg_dump.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c index becc82be91e..f74935e0b93 100644 --- a/src/bin/pg_dump/pg_dump.c +++ b/src/bin/pg_dump/pg_dump.c @@ -5746,7 +5746,7 @@ EventTriggerInfo * getEventTriggers(Archive *fout, int *numEventTriggers) { int i; - PQExpBuffer query = createPQExpBuffer(); + PQExpBuffer query; PGresult *res; EventTriggerInfo *evtinfo; int i_tableoid, @@ -5766,6 +5766,8 @@ getEventTriggers(Archive *fout, int *numEventTriggers) return NULL; } + query = createPQExpBuffer(); + /* Make sure we are in proper schema */ selectSourceSchema(fout, "pg_catalog"); |