diff options
| author | Andrew Dunstan <andrew@dunslane.net> | 2023-03-12 09:00:32 -0400 |
|---|---|---|
| committer | Andrew Dunstan <andrew@dunslane.net> | 2023-03-12 09:00:32 -0400 |
| commit | 872e3d150e9aad110cfbd80c38b15e2219eacf45 (patch) | |
| tree | 4485ba46baa18a7638367561cd53c5034c428800 /src | |
| parent | a4f23f9b3cddb86137a3b1683dcbe49d8b41ea7b (diff) | |
| download | postgresql-872e3d150e9aad110cfbd80c38b15e2219eacf45.tar.gz postgresql-872e3d150e9aad110cfbd80c38b15e2219eacf45.zip | |
Mark unsafe_tests module as not runnable with installcheck
This was an omission in the original creation of the module.
Also slightly adjust some wording to avoid a double "is".
Backpatch the non-meson piece of this to release 12, where the module
was introduced.
Discussion: https://postgr.es/m/be869e1c-8e3f-4cde-8609-212c899cccf9@dunslane.net
Diffstat (limited to 'src')
| -rw-r--r-- | src/test/modules/unsafe_tests/Makefile | 3 | ||||
| -rw-r--r-- | src/test/modules/unsafe_tests/README | 2 | ||||
| -rw-r--r-- | src/test/modules/unsafe_tests/meson.build | 1 |
3 files changed, 5 insertions, 1 deletions
diff --git a/src/test/modules/unsafe_tests/Makefile b/src/test/modules/unsafe_tests/Makefile index df582736884..90d19791871 100644 --- a/src/test/modules/unsafe_tests/Makefile +++ b/src/test/modules/unsafe_tests/Makefile @@ -2,6 +2,9 @@ REGRESS = rolenames alter_system_table guc_privs +# the whole point of these tests is to not run installcheck +NO_INSTALLCHECK = 1 + ifdef USE_PGXS PG_CONFIG = pg_config PGXS := $(shell $(PG_CONFIG) --pgxs) diff --git a/src/test/modules/unsafe_tests/README b/src/test/modules/unsafe_tests/README index a7e5b2a04f5..d9dbd038b95 100644 --- a/src/test/modules/unsafe_tests/README +++ b/src/test/modules/unsafe_tests/README @@ -1,6 +1,6 @@ This directory doesn't actually contain any extension module. -What it is is a home for regression tests that we don't want to run +Instead it is a home for regression tests that we don't want to run during "make installcheck" because they could have side-effects that seem undesirable for a production installation. diff --git a/src/test/modules/unsafe_tests/meson.build b/src/test/modules/unsafe_tests/meson.build index 304f0ed61a2..b6806e4a017 100644 --- a/src/test/modules/unsafe_tests/meson.build +++ b/src/test/modules/unsafe_tests/meson.build @@ -10,5 +10,6 @@ tests += { 'alter_system_table', 'guc_privs', ], + 'runningcheck': false, }, } |