diff options
| author | Andres Freund <andres@anarazel.de> | 2023-04-03 18:02:41 -0700 |
|---|---|---|
| committer | Andres Freund <andres@anarazel.de> | 2023-04-03 18:02:41 -0700 |
| commit | 8a2b1b147728b11f6df569081d121b9e3135109d (patch) | |
| tree | e323e4e7220e4e4dde0d4f4de4a5a381aa6d32a8 /src | |
| parent | 05a304a855104a8eb6394e044bfbc8e761a4d635 (diff) | |
| download | postgresql-8a2b1b147728b11f6df569081d121b9e3135109d.tar.gz postgresql-8a2b1b147728b11f6df569081d121b9e3135109d.zip | |
bufmgr: Remove buffer-write-dirty tracepoints
The trace point was using the relfileno / fork / block for the to-be-read-in
buffer. Some upcoming work would make that more expensive to provide. We still
have buffer-flush-start/done, which can serve most tracing needs that
buffer-write-dirty could serve.
Discussion: https://postgr.es/m/f5164e7a-eef6-8972-75a3-8ac622ed0c6e@iki.fi
Diffstat (limited to 'src')
| -rw-r--r-- | src/backend/storage/buffer/bufmgr.c | 10 | ||||
| -rw-r--r-- | src/backend/utils/probes.d | 2 |
2 files changed, 0 insertions, 12 deletions
diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c index b3adbbe7d23..7f119cd4b0f 100644 --- a/src/backend/storage/buffer/bufmgr.c +++ b/src/backend/storage/buffer/bufmgr.c @@ -1280,21 +1280,11 @@ BufferAlloc(SMgrRelation smgr, char relpersistence, ForkNumber forkNum, } /* OK, do the I/O */ - TRACE_POSTGRESQL_BUFFER_WRITE_DIRTY_START(forkNum, blockNum, - smgr->smgr_rlocator.locator.spcOid, - smgr->smgr_rlocator.locator.dbOid, - smgr->smgr_rlocator.locator.relNumber); - FlushBuffer(buf, NULL, IOOBJECT_RELATION, io_context); LWLockRelease(BufferDescriptorGetContentLock(buf)); ScheduleBufferTagForWriteback(&BackendWritebackContext, &buf->tag); - - TRACE_POSTGRESQL_BUFFER_WRITE_DIRTY_DONE(forkNum, blockNum, - smgr->smgr_rlocator.locator.spcOid, - smgr->smgr_rlocator.locator.dbOid, - smgr->smgr_rlocator.locator.relNumber); } else { diff --git a/src/backend/utils/probes.d b/src/backend/utils/probes.d index c064d679e94..204a2649b09 100644 --- a/src/backend/utils/probes.d +++ b/src/backend/utils/probes.d @@ -66,8 +66,6 @@ provider postgresql { probe buffer__sync__start(int, int); probe buffer__sync__written(int); probe buffer__sync__done(int, int, int); - probe buffer__write__dirty__start(ForkNumber, BlockNumber, Oid, Oid, Oid); - probe buffer__write__dirty__done(ForkNumber, BlockNumber, Oid, Oid, Oid); probe deadlock__found(); |