diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2013-01-20 23:43:46 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2013-01-20 23:43:46 -0500 |
| commit | 8f0d8f481e86514bb35538827df7e1e35baee368 (patch) | |
| tree | 06dba130e79276872e28d57c703137b3fdc36430 /src | |
| parent | 535e69a43f14673557d281b112859e7a25cc7939 (diff) | |
| download | postgresql-8f0d8f481e86514bb35538827df7e1e35baee368.tar.gz postgresql-8f0d8f481e86514bb35538827df7e1e35baee368.zip | |
Fix one-byte buffer overrun in PQprintTuples().
This bug goes back to the original Postgres95 sources. Its significance
to modern PG versions is marginal, since we have not used PQprintTuples()
internally in a very long time, and it doesn't seem to have ever been
documented either. Still, it *is* exposed to client apps, so somebody
out there might possibly be using it.
Xi Wang
Diffstat (limited to 'src')
| -rw-r--r-- | src/interfaces/libpq/fe-print.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/src/interfaces/libpq/fe-print.c b/src/interfaces/libpq/fe-print.c index 076e1ccfc5b..5c86f037d71 100644 --- a/src/interfaces/libpq/fe-print.c +++ b/src/interfaces/libpq/fe-print.c @@ -681,7 +681,6 @@ PQprintTuples(const PGresult *res, int i, j; char formatString[80]; - char *tborder = NULL; nFields = PQnfields(res); @@ -700,15 +699,15 @@ PQprintTuples(const PGresult *res, int width; width = nFields * 14; - tborder = malloc(width + 1); + tborder = (char *) malloc(width + 1); if (!tborder) { fprintf(stderr, libpq_gettext("out of memory\n")); abort(); } - for (i = 0; i <= width; i++) + for (i = 0; i < width; i++) tborder[i] = '-'; - tborder[i] = '\0'; + tborder[width] = '\0'; fprintf(fout, "%s\n", tborder); } |